Skip to content

MINOR: refactor error message of task migration#4803

Merged
guozhangwang merged 2 commits into
apache:trunkfrom
guozhangwang:KMinor-task-migration-error-message
Apr 2, 2018
Merged

MINOR: refactor error message of task migration#4803
guozhangwang merged 2 commits into
apache:trunkfrom
guozhangwang:KMinor-task-migration-error-message

Conversation

@guozhangwang

Copy link
Copy Markdown
Contributor

In the stream thread capture of the TaskMigration exception, print the task full information in WARN. In other places only log as INFO, plus additional context information.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@guozhangwang

Copy link
Copy Markdown
Contributor Author

@mjsax @bbejeck @vvcephei

Some nit improvement on log4j I realized while trouble shooting a related issue.

@mjsax

mjsax commented Mar 31, 2018

Copy link
Copy Markdown
Member

Change looks good. You need to update some test though.

@guozhangwang

Copy link
Copy Markdown
Contributor Author

Change looks good. You need to update some test though.

Ack, updated to fix the unit tests.

@bbejeck bbejeck left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @guozhangwang LGTM

@mjsax mjsax added the streams label Apr 1, 2018
@guozhangwang
guozhangwang merged commit 2e5d4af into apache:trunk Apr 2, 2018
@guozhangwang
guozhangwang deleted the KMinor-task-migration-error-message branch April 24, 2020 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants