Skip to content

MINOR: change exception.getMessage to toString #4790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guozhangwang merged 1 commit into from
Mar 28, 2018
Merged

MINOR: change exception.getMessage to toString #4790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions streams/src/main/java/org/apache/kafka/streams/processor/internals/AssignedTasks.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ void initializeNewTasks() {
it.remove();
} catch (final LockException e) {
// made this trace as it will spam the logs in the poll loop.
log.trace("Could not create {} {} due to {}; will retry", taskTypeName, entry.getKey(), e.getMessage());
log.trace("Could not create {} {} due to {}; will retry", taskTypeName, entry.getKey(), e.toString());
}
}
}
Expand Down Expand Up @@ -204,7 +204,7 @@ RuntimeException closeZombieTask(final T task) {
try {
task.close(false, true);
} catch (final RuntimeException e) {
log.warn("Failed to close zombie {} {} due to {}; ignore and proceed.", taskTypeName, task.id(), e.getMessage());
log.warn("Failed to close zombie {} {} due to {}; ignore and proceed.", taskTypeName, task.id(), e.toString());
return e;
}
return null;
Expand Down
4 changes: 2 additions & 2 deletions ...ms/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ private void restoreState(final StateRestoreCallback stateRestoreCallback,
} catch (final InvalidOffsetException recoverableException) {
log.warn("Restoring GlobalStore {} failed due to: {}. Deleting global store to recreate from scratch.",
storeName,
recoverableException.getMessage());
recoverableException.toString());
reinitializeStateStoresForPartitions(recoverableException.partitions(), processorContext);

stateRestoreListener.onRestoreStart(topicPartition, storeName, offset, highWatermark);
Expand Down Expand Up @@ -318,7 +318,7 @@ public void close(final Map<TopicPartition, Long> offsets) throws IOException {
closeFailed.append("Failed to close global state store:")
.append(entry.getKey())
.append(". Reason: ")
.append(e.getMessage())
.append(e.toString())
.append("\n");
}
}
Expand Down
8 changes: 4 additions & 4 deletions streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,9 +130,9 @@ public void makeReady(final Map<String, InternalTopicConfig> topics) {
"Will try again (remaining retries {}).", topicName, remainingRetries - 1);
} else if (cause instanceof TopicExistsException) {
createTopicNames.add(createTopicResult.getKey());
log.info(String.format("Topic %s exist already: %s",
log.info("Topic {} exist already: {}",
topicName,
couldNotCreateTopic.getMessage()));
couldNotCreateTopic.toString());
} else {
throw new StreamsException(String.format("Could not create topic %s.", topicName),
couldNotCreateTopic);
Expand Down Expand Up @@ -197,8 +197,8 @@ protected Map<String, Integer> getNumPartitions(final Set<String> topics) {
log.debug("Could not get number of partitions for topic {} due to timeout. " +
"Will try again (remaining retries {}).", topicFuture.getKey(), remainingRetries - 1);
} else {
final String error = "Could not get number of partitions for topic {}.";
log.debug(error, topicFuture.getKey(), cause.getMessage());
final String error = "Could not get number of partitions for topic {} due to {}";
log.debug(error, topicFuture.getKey(), cause.toString());
}
}
}
Expand Down
8 changes: 4 additions & 4 deletions streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ private <K, V> void recordSendError(
value,
timestamp,
topic,
exception.getMessage()),
exception.toString()),
exception);
}

Expand Down Expand Up @@ -163,7 +163,7 @@ public void onCompletion(final RecordMetadata metadata,
} else {
if (sendException == null) {
if (exception instanceof ProducerFencedException) {
log.warn(LOG_MESSAGE, key, value, timestamp, topic, exception.getMessage());
log.warn(LOG_MESSAGE, key, value, timestamp, topic, exception.toString());
sendException = new ProducerFencedException(
String.format(EXCEPTION_MESSAGE,
logPrefix,
Expand All @@ -172,7 +172,7 @@ public void onCompletion(final RecordMetadata metadata,
value,
timestamp,
topic,
exception.getMessage()));
exception.toString()));
} else {
if (productionExceptionIsFatal(exception)) {
recordSendError(key, value, timestamp, topic, exception);
Expand Down Expand Up @@ -201,7 +201,7 @@ public void onCompletion(final RecordMetadata metadata,
value,
timestamp,
topic,
uncaughtException.getMessage()),
uncaughtException.toString()),
uncaughtException);
}
}
Expand Down
4 changes: 2 additions & 2 deletions streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ public void onPartitionsAssigned(final Collection<TopicPartition> assignment) {
taskManager.createTasks(assignment);
} catch (final Throwable t) {
log.error("Error caught during partition assignment, " +
"will abort the current process and re-throw at the end of rebalance: {}", t.getMessage());
"will abort the current process and re-throw at the end of rebalance: {}", t);
streamThread.setRebalanceException(t);
} finally {
log.info("partition assignment took {} ms.\n" +
Expand Down Expand Up @@ -291,7 +291,7 @@ public void onPartitionsRevoked(final Collection<TopicPartition> assignment) {
taskManager.suspendTasksAndState();
} catch (final Throwable t) {
log.error("Error caught during partition revocation, " +
"will abort the current process and re-throw at the end of rebalance: {}", t.getMessage());
"will abort the current process and re-throw at the end of rebalance: {}", t);
streamThread.setRebalanceException(t);
} finally {
streamThread.clearStandbyRecords();
Expand Down