Skip to content

KAFKA-5940: Throw exception if the JSON file is invalid#3920

Closed
scholzj wants to merge 1 commit into
apache:trunkfrom
scholzj:KAFKA-5940
Closed

KAFKA-5940: Throw exception if the JSON file is invalid#3920
scholzj wants to merge 1 commit into
apache:trunkfrom
scholzj:KAFKA-5940

Conversation

@scholzj

@scholzj scholzj commented Sep 20, 2017

Copy link
Copy Markdown
Member

Throw an exception when the JSON file with topics/partitions and offsets is incorrect (= when Json.parseFull(...) returns None).

@scholzj scholzj changed the title KAFKA5940: Throw exception if the JSON file is invalid KAFKA-5940: Throw exception if the JSON file is invalid Sep 25, 2017
@ppatierno

ppatierno commented Sep 29, 2017

Copy link
Copy Markdown
Contributor

@scholzj I see that your PR is overlapping with this one from me (#3887) because while adding some checks on the "version" field, I have started to add a more fine grained checks on the JSON file. Sorry for that. Is it worth having this PR still opened ?

@scholzj

scholzj commented Sep 29, 2017

Copy link
Copy Markdown
Member Author

@ppatierno Sure, if your PR fixes this I can close it. We should also deal with the KAFKA-5940 issues once your PR is merged.

@scholzj scholzj closed this Sep 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants