KAFKA-2419 - Fix to prevent background thread from getting created when not required#323
Closed
auradkar wants to merge 1 commit into
Closed
KAFKA-2419 - Fix to prevent background thread from getting created when not required#323auradkar wants to merge 1 commit into
auradkar wants to merge 1 commit into
Conversation
…hread from getting created if the Metrics instance does not support expiration
Contributor
There was a problem hiding this comment.
@auradkar Just a tip (no need to change, up to you): you can use Collections.singletonList() instead of Arrays.asList when dealing with only a single element collection. ;-)
Contributor
|
Thanks for the patch. LGTM |
efeg
added a commit
to efeg/kafka
that referenced
this pull request
Jan 29, 2020
abbccdda
pushed a commit
to abbccdda/kafka
that referenced
this pull request
May 12, 2020
Observers were not being created in the simulation test due to an invalid range check. This patch fixes the range check.
abbccdda
pushed a commit
to abbccdda/kafka
that referenced
this pull request
May 31, 2020
Observers were not being created in the simulation test due to an invalid range check. This patch fixes the range check.
hachikuji
pushed a commit
to hachikuji/kafka
that referenced
this pull request
Aug 5, 2020
Observers were not being created in the simulation test due to an invalid range check. This patch fixes the range check.
hachikuji
pushed a commit
to hachikuji/kafka
that referenced
this pull request
Aug 13, 2020
Observers were not being created in the simulation test due to an invalid range check. This patch fixes the range check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See here for more discussion: https://issues.apache.org/jira/browse/KAFKA-2419
Basically, the fix involves adding a param to Metrics to indicate if it is capable of metric cleanup or not.