MINOR: Reduce logging level for controller connection failures from error to warn#280
Closed
ijuma wants to merge 1 commit into
Closed
MINOR: Reduce logging level for controller connection failures from error to warn#280ijuma wants to merge 1 commit into
error to warn#280ijuma wants to merge 1 commit into
Conversation
…to `warn` Before we switched from `BlockingChannel` to `NetworkClient`, we were always reporting a successful connection due to the fact that `BlockingChannel.connect` catches and swallows all exceptions. We are now reporting failures (which is better), but `error` seems too noisy (as can be seen in our tests).
ijuma
changed the title
error to warnerror to warn
Member
Author
|
Review by @junrao please. |
Contributor
|
Thanks for the patch. LGTM |
efeg
added a commit
to efeg/kafka
that referenced
this pull request
Jan 29, 2020
davide-armand
pushed a commit
to aiven/kafka
that referenced
this pull request
Dec 1, 2025
* Consistently name versioned types * Consistently name function arguments * Consistently name function local variables * Various small changes * Add missing indices
jeqo
pushed a commit
to aiven/kafka
that referenced
this pull request
Jan 16, 2026
* Consistently name versioned types * Consistently name function arguments * Consistently name function local variables * Various small changes * Add missing indices
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before we switched from
BlockingChanneltoNetworkClient, we werealways reporting a successful connection due to the fact that
BlockingChannel.connectcatches and swallows all exceptions. Weare now reporting failures (which is better), but
errorseems toonoisy (as can be seen in our tests).