Skip to content

HOTFIX: Persistent store in ProcessorStateManagerTest #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
guozhangwang wants to merge 2 commits into from
Closed

HOTFIX: Persistent store in ProcessorStateManagerTest #276

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfcbb71
fix ProcessorStateManagerTest
guozhangwang Oct 5, 2015
3cc6b52
Ismael's comments
guozhangwang Oct 5, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...src/test/java/org/apache/kafka/streams/processor/internals/ProcessorStateManagerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ public void testRegisterPersistentStore() throws IOException {
));
restoreConsumer.updateEndOffsets(Collections.singletonMap(new TopicPartition("persistentStore", 2), 13L));

MockStateStore persistentStore = new MockStateStore("persistentStore", false); // non persistent store
MockStateStore persistentStore = new MockStateStore("persistentStore", true); // persistent store

ProcessorStateManager stateMgr = new ProcessorStateManager(2, baseDir, restoreConsumer);
try {
Expand Down Expand Up @@ -331,7 +331,7 @@ public void testRegisterNonPersistentStore() throws IOException {
));
restoreConsumer.updateEndOffsets(Collections.singletonMap(new TopicPartition("persistentStore", 2), 13L));

MockStateStore nonPersistentStore = new MockStateStore("nonPersistentStore", true); // persistent store
MockStateStore nonPersistentStore = new MockStateStore("nonPersistentStore", true); // non persistent store

@ijuma ijuma Oct 5, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be false?

@guozhangwang guozhangwang Oct 5, 2015

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, thanks.


ProcessorStateManager stateMgr = new ProcessorStateManager(2, baseDir, restoreConsumer);
try {
Expand Down