Skip to content

MINOR: Fixed README examples on running specific tests.#268

Closed
GabrielNicolasAvellaneda wants to merge 1 commit into
apache:trunkfrom
GabrielNicolasAvellaneda:readme-updates
Closed

MINOR: Fixed README examples on running specific tests.#268
GabrielNicolasAvellaneda wants to merge 1 commit into
apache:trunkfrom
GabrielNicolasAvellaneda:readme-updates

Conversation

@GabrielNicolasAvellaneda

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: GabrielNicolasAvellaneda <avellaneda.gabriel@gmail.com>
@GabrielNicolasAvellaneda GabrielNicolasAvellaneda changed the title Fixed examples on running specific tests. README: Fixed examples on running specific tests. Oct 1, 2015
@GabrielNicolasAvellaneda

Copy link
Copy Markdown
Contributor Author

Hey Guys, do I need to create a Jira Issue for the README fix?

@ijuma

ijuma commented Oct 1, 2015

Copy link
Copy Markdown
Member

Thanks for the fix. You don't need a JIRA, but it would be good if you could edit the PR title to be:

MINOR: Fixed README examples on running specific tests

The change itself LGTM.

@ijuma

ijuma commented Oct 1, 2015

Copy link
Copy Markdown
Member

Also, we don't use Signed-off-by in the Kafka project.

@GabrielNicolasAvellaneda GabrielNicolasAvellaneda changed the title README: Fixed examples on running specific tests. MINOR: Fixed README examples on running specific tests. Oct 1, 2015
@GabrielNicolasAvellaneda

Copy link
Copy Markdown
Contributor Author

Thanks @ijuma 👍

@ewencp

ewencp commented Oct 5, 2015

Copy link
Copy Markdown
Contributor

LGTM.

@GabrielNicolasAvellaneda

Copy link
Copy Markdown
Contributor Author

@ewencp Do I need to do anything else for this PR to be merged?

@ewencp

ewencp commented Oct 5, 2015

Copy link
Copy Markdown
Contributor

@GabrielNicolasAvellaneda I assigned you on the JIRA, marked it as "Patch Available" and assigned Guozhang as a reviewer so it'll be noticed. Unless someone raises an issue, you shouldn't need to do anything except remind us if it gets lost in the shuffle.

Thanks for the patch!

@GabrielNicolasAvellaneda

Copy link
Copy Markdown
Contributor Author

@ewencp Thanks for your response.
Okay, Perfect, more changes are coming soon... :)
Happy to help. 👍

@GabrielNicolasAvellaneda

Copy link
Copy Markdown
Contributor Author

LGTM 👍

@ijuma

ijuma commented Oct 17, 2015

Copy link
Copy Markdown
Member

Simple README fix, could you please merge it @gwenshap?

@guozhangwang

Copy link
Copy Markdown
Contributor

Thanks, LGTM.

@asfgit asfgit closed this in 241b9ab Oct 19, 2015
jeqo added a commit to aiven/kafka that referenced this pull request Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants