HOTFIX: Checkstye fixes follow up for KAKFA-2531.#248
Closed
ewencp wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
@gwenshap Some minor checkstyle issues were missed in KAFKA-2531, probably because of the other transient test failures that kept checkstyle from running in the Jenkins tests. |
|
kafka-trunk-git-pr #569 FAILURE |
Member
There was a problem hiding this comment.
Is it worth fixing these bad indents at the same time?
Contributor
|
Completely agree that we need to fix the bad indents, but merging this PR anyway to unblock the build. @ijuma feel free to throw in a PR for the indents. |
Member
jsancio
pushed a commit
to jsancio/kafka
that referenced
this pull request
Aug 6, 2019
…apache#248) Reviewers: Manikumar Reddy <manikumar.reddy@gmail.com>
efeg
added a commit
to efeg/kafka
that referenced
this pull request
Jan 29, 2020
soondenana
added a commit
to soondenana/kafka
that referenced
this pull request
Feb 6, 2020
* CONFLUENT: Bump up version to 5.4.1 Now that 5.4.0 is out, this change bumps up the version to 5.4.1-ccs-SNAPSHOT Co-authored-by: Ewen Cheslack-Postava <me@ewencp.org>
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Jan 19, 2022
This also squashes the directly related test commits - e59b0da [LI-HOTFIX] Add test case for describe maintenance broker config (apache#248) - 1f7bab6 [LI-HOTFIX] fix DynamicConfig and DynamicBrokerConfig cross reference issue (apache#69) TICKET = KAFKA-8527 LI_DESCRIPTION = When a broker is masked as maintenance broker, Kafka will not assign partitions of new topics to the broker if partition assignment is done by kafka brokers. 1) add dynamic broker config to support maintenance brokers 2) add logic to update maintenance broker info in controller 3) support maintenance broker in Kafka API 4) support maintenance broker in AdminZkClient 5) add logic to rearrange replica assignment for new topics for maintenance brokers 5) test cases RB=1484649 G=Kafka-Code-Reviews R=agencer, amendhek, jkoshy, zahuang A=zahuang EXIT_CRITERIA = TICKET [KAFKA-8527]
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Jan 21, 2022
…che#248) TICKET = KAFKA-8527 LI_DESCRIPTION = In the commit 6b93c27 `[LI-HOTFIX] Add dynamic maintenance broker config`, the test cases didn't cover the `describeConfigs` API. Adding an integration test case to protect the code path and facilitate the future rebase process. EXIT_CRITERIA = TICKET [KAFKA-8527] or the patch is dropped
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Mar 4, 2022
This also squashes the directly related test commits - e59b0da [LI-HOTFIX] Add test case for describe maintenance broker config (apache#248) - 1f7bab6 [LI-HOTFIX] fix DynamicConfig and DynamicBrokerConfig cross reference issue (apache#69) TICKET = KAFKA-8527 LI_DESCRIPTION = When a broker is masked as maintenance broker, Kafka will not assign partitions of new topics to the broker if partition assignment is done by kafka brokers. 1) add dynamic broker config to support maintenance brokers 2) add logic to update maintenance broker info in controller 3) support maintenance broker in Kafka API 4) support maintenance broker in AdminZkClient 5) add logic to rearrange replica assignment for new topics for maintenance brokers 5) test cases RB=1484649 G=Kafka-Code-Reviews R=agencer, amendhek, jkoshy, zahuang A=zahuang EXIT_CRITERIA = TICKET [KAFKA-8527]
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Mar 28, 2022
This also squashes the directly related test commits - e59b0da [LI-HOTFIX] Add test case for describe maintenance broker config (apache#248) - 1f7bab6 [LI-HOTFIX] fix DynamicConfig and DynamicBrokerConfig cross reference issue (apache#69) TICKET = KAFKA-8527 LI_DESCRIPTION = When a broker is masked as maintenance broker, Kafka will not assign partitions of new topics to the broker if partition assignment is done by kafka brokers. 1) add dynamic broker config to support maintenance brokers 2) add logic to update maintenance broker info in controller 3) support maintenance broker in Kafka API 4) support maintenance broker in AdminZkClient 5) add logic to rearrange replica assignment for new topics for maintenance brokers 5) test cases RB=1484649 G=Kafka-Code-Reviews R=agencer, amendhek, jkoshy, zahuang A=zahuang EXIT_CRITERIA = TICKET [KAFKA-8527]
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Jun 16, 2022
This also squashes the directly related test commits - e59b0da [LI-HOTFIX] Add test case for describe maintenance broker config (apache#248) - 1f7bab6 [LI-HOTFIX] fix DynamicConfig and DynamicBrokerConfig cross reference issue (apache#69) TICKET = KAFKA-8527 LI_DESCRIPTION = When a broker is masked as maintenance broker, Kafka will not assign partitions of new topics to the broker if partition assignment is done by kafka brokers. 1) add dynamic broker config to support maintenance brokers 2) add logic to update maintenance broker info in controller 3) support maintenance broker in Kafka API 4) support maintenance broker in AdminZkClient 5) add logic to rearrange replica assignment for new topics for maintenance brokers 5) test cases RB=1484649 G=Kafka-Code-Reviews R=agencer, amendhek, jkoshy, zahuang A=zahuang EXIT_CRITERIA = TICKET [KAFKA-8527]
udaynpusa
pushed a commit
to mapr/kafka
that referenced
this pull request
Jan 30, 2024
…pache#248) Co-authored-by: Yaroslav Chernysh <yarocher01@gmail.com>
davide-armand
pushed a commit
to aiven/kafka
that referenced
this pull request
Dec 1, 2025
jeqo
pushed a commit
to aiven/kafka
that referenced
this pull request
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.