KAFKA-19449: Don't consider partitions unreleased when pending revocation by the current member #20781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion by the current member During reconciliation, we transition members to UNRELEASED_PARTITIONS when the target assignment contains a partition that is owned by another member. Partitions are considered owned by another member if they are in a member's assignment or partitions pending revocation. Ownership is only updated after reconciliation has finished. Fix a bug where we consider a partition owned by another member when it is actually in the current member's list of partitions pending revocation. In some cases, this skips a transition to UNRELEASED_PARTITIONS and allows the current assignment to converge to the target assignment one heartbeat sooner.
github-actions
bot
added
triage
| assertEquals( | ||
| new ConsumerGroupMember.Builder("member") | ||
| .setState(MemberState.STABLE) | ||
| .setMemberEpoch(12) |
There was a problem hiding this comment.
I’m wondering if there’s any specific reason behind using 12 as the next member epoch? The previous member epoch is 10.
There was a problem hiding this comment.
It just needs to be at least 2 more than the previous epoch to be realistic. Epoch 11's assignment would have moved the partition away from the member and epoch 12's assignment would have returned the partition. It doesn't actually impact the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During reconciliation, we transition members to UNRELEASED_PARTITIONS
when the target assignment contains a partition that is owned by another
member. Partitions are considered owned by another member if they are in
a member's assignment or partitions pending revocation. Ownership is
only updated after reconciliation has finished.
Fix a bug where we consider a partition owned by another member when it
is actually in the current member's list of partitions pending
revocation. In some cases, this skips a transition to
UNRELEASED_PARTITIONS and allows the current assignment to converge to
the target assignment one heartbeat sooner.