KAFKA-16263 : Add Kafka Streams docs about available listeners/callback#20430
Conversation
dbe9d34
|
Hi @AndrewJSchofield / @mjsax, This PR is not valid as it contains changes in the trunk branch, which conflicts with other PRs. We decided to reset the trunk. The actual PR can be found here: #20589 Created by @samarth-ksolves |
|
@abhi-ksolves @AndrewJSchofield -- I am somewhat confused.
What is this supposed to mean? I cannot find any commit for this PR in This PR also says on top
And has zero commits. Any idea why? |
|
@mjsax Let me clarify the confusion. The usual practice is that whenever we need to work on a ticket, we create a new branch from trunk (for example, Kafka-), apply our changes there, and then open a PR from that branch to Kafka/trunk. In our case, @samarth-ksolves and I share the same forked Kafka repository for contributions. What happened here is that @samarth-ksolves initially created a PR directly from the forked trunk branch to Kafka/trunk. At that point, you saw 1 file change with more than 0 commits. On my side, the unmerged commits in our forked trunk branch caused issues when I tried to create a different branch that inherited the commits from this PR. To fix this, I reset our forked trunk, which in turn resulted in this PR showing 0 commits and 0 file changes. At this point, commits are 0 and file changes are 0. After this whole event, @AndrewJSchofield merged the PR. |
|
I merged #20385. |
|
Hi @AndrewJSchofield |
|
Ah. Thanks for clarifying :) |
|
@AndrewJSchofield How is #20385 related? Seems to be some unrelated PR? |
Just some git confusion I think. They're not related. |
This PR updated the running-app.html to: