MINOR: restore testUnauthorizedTopicMetadataRequest - #18578
Merged
Conversation
github-actions
Bot
added
triage
3 tasks
chia7712
approved these changes
Jan 16, 2025
|
|
||
| val updateMetadataRequest = new UpdateMetadataRequest.Builder(ApiKeys.UPDATE_METADATA.latestVersion, 0, | ||
| 0, 0, partitionStates.asJava, Seq(broker).asJava, topicIds).build() | ||
| MetadataCacheTest.updateCache(metadataCache, updateMetadataRequest) |
Member
There was a problem hiding this comment.
we should have a jira to cleanup the usage of MetadataCacheTest.updateCache, as it is using updateMetadataRequest which is not used by kraft production code anymore.
Collaborator
Author
There was a problem hiding this comment.
Yes, this is already trace by https://issues.apache.org/jira/browse/KAFKA-18540.
I will handle it ASAP.
3 tasks
ijuma
changed the title
Member
|
Failures are clearly unrelated since this is not changing any non test code:
|
ijuma
pushed a commit
that referenced
this pull request
Jan 19, 2025
This was removed during removal of zk code (#18542), but we should instead convert it to work with kraft. Reviewers: Ismael Juma <ismael@juma.me.uk>, Chia-Ping Tsai <chia7712@gmail.com>
pranavt84
pushed a commit
to pranavt84/kafka
that referenced
this pull request
Jan 27, 2025
This was removed during removal of zk code (apache#18542), but we should instead convert it to work with kraft. Reviewers: Ismael Juma <ismael@juma.me.uk>, Chia-Ping Tsai <chia7712@gmail.com>
airlock-confluentinc Bot
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Jan 27, 2025
This was removed during removal of zk code (apache#18542), but we should instead convert it to work with kraft. Reviewers: Ismael Juma <ismael@juma.me.uk>, Chia-Ping Tsai <chia7712@gmail.com>
manoj-mathivanan
pushed a commit
to manoj-mathivanan/kafka
that referenced
this pull request
Feb 19, 2025
This was removed during removal of zk code (apache#18542), but we should instead convert it to work with kraft. Reviewers: Ismael Juma <ismael@juma.me.uk>, Chia-Ping Tsai <chia7712@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was removed during removal of zk code (#18542), but we should instead convert it to work with kraft.
Committer Checklist (excluded from commit message)