Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR Use new Develocity API key #18229

Merged
merged 3 commits into from
Dec 17, 2024
Merged

MINOR Use new Develocity API key #18229

merged 3 commits into from
Dec 17, 2024

Conversation

mumrah
Copy link
Member

@mumrah mumrah commented Dec 17, 2024 •
edited
Loading

Use the new secret provided by the apache GitHub org.

@github-actions github-actions bot added build Gradle build or GitHub Actions small Small PRs labels Dec 17, 2024
@mumrah mumrah requested review from chia7712 and mimaison December 17, 2024 17:46
@mumrah
Copy link
Member Author

mumrah commented Dec 17, 2024

Ran it using a temporary pull_request trigger here https://github.com/apache/kafka/actions/runs/12374369064/job/34536734813?pr=18229

@mimaison
Copy link
Member

How did we get the new key?

@mumrah
Copy link
Member Author

mumrah commented Dec 17, 2024

The key is managed by ASF Infra as a GitHub organization level secret. Prior to this patch, I was parsing the access key that is normally passed to Gradle (GE_ACCESS_TOKEN) which wasn't quite correct. After chatting with Infra, they have provisioned a separate key that's just for API access and added it as the DV_API_ACCESS secret.

mimaison
mimaison approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@mimaison mimaison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mimaison
Copy link
Member

After chatting with Infra, they have provisioned a separate key that's just for API access and added it as the DV_API_ACCESS secret.

Is there an INFRA jira?

@mumrah
Copy link
Member Author

mumrah commented Dec 17, 2024 •
edited
Loading

Is there an INFRA jira?

No, it happened via the ASF Slack.

@mumrah mumrah merged commit 7697d3b into trunk Dec 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimaison mimaison mimaison approved these changes

@chia7712 chia7712 Awaiting requested review from chia7712

Assignees
No one assigned
Labels
build Gradle build or GitHub Actions small Small PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mumrah @mimaison