Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-18025: Re-enable few tests in ShareConsumerTest. #18226

Merged
merged 1 commit into from
Dec 17, 2024
Merged

KAFKA-18025: Re-enable few tests in ShareConsumerTest. #18226

merged 1 commit into from
Dec 17, 2024

Conversation

ShivsundarR
Copy link
Contributor

What
After observing clean builds for a few tests over last 2 weeks, we are re-enabling some of these tests in the ShareConsumerTest suite.

@github-actions github-actions bot added triage PRs from the community core Kafka Broker tests Test fixes (including flaky tests) small Small PRs labels Dec 17, 2024
@mumrah
Copy link
Member

mumrah commented Dec 17, 2024

Indeed, the report looks pretty good for this class https://ge.apache.org/scans/tests?search.relativeStartTime=P28D&search.rootProjectNames=kafka&search.tags=github,trunk&search.timeZoneId=America%2FNew_York&tests.container=kafka.test.api.ShareConsumerTest#

Looks like only two quarantined tests remain for this class:

mumrah
mumrah approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@mumrah mumrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot removed the triage PRs from the community label Dec 17, 2024
@mumrah mumrah merged commit e88fede into apache:trunk Dec 17, 2024
10 checks passed
tedyu pushed a commit to tedyu/kafka that referenced this pull request Jan 6, 2025
@ShivsundarR @tedyu
KAFKA-18025 Remove flaky tag from several tests in ShareConsumerTest (a…
a6f88fc 
…pache#18226)

Develocity report: https://ge.apache.org/scans/tests?search.relativeStartTime=P28D&search.rootProjectNames=kafka&search.tags=github,trunk&search.timeZoneId=America%2FNew_York&tests.container=kafka.test.api.ShareConsumerTest#

Reviewers: David Arthur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mumrah mumrah mumrah approved these changes

Assignees
No one assigned
Labels
core Kafka Broker small Small PRs tests Test fixes (including flaky tests)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShivsundarR @mumrah