Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-15474: Disable flaky testWakeupAfterSyncGroupReceivedExternalCompletion #18188

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

frankvicky
Copy link
Contributor

JIRA: KAFKA-15474

as title, since test-common:test-common-api requires Java 17, we use @Disable instead.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@github-actions github-actions bot added triage PRs from the community consumer tests Test fixes (including flaky tests) clients small Small PRs labels Dec 15, 2024
@chia7712 chia7712 changed the title KAFKA-15474: Disable flaky test KAFKA-15474: Disable flaky testWakeupAfterSyncGroupReceivedExternalCompletion Dec 15, 2024
@chia7712 chia7712 merged commit 0781b1b into apache:trunk Dec 15, 2024
10 checks passed
@mumrah
Copy link
Member

mumrah commented Dec 18, 2024

Should we have marked this test as flaky instead of disabling it? E.g., @Tag("flaky")

@chia7712
Copy link
Member

Should we have marked this test as flaky instead of disabling it? E.g., @tag("flaky")

You are right - it is always better to have more Gradle report.

@frankvicky could you please file a minor to address it? BTW, please keep the jira reference

@chia7712
Copy link
Member

oh, you have filed the PR #18263

@github-actions github-actions bot removed the triage PRs from the community label Dec 19, 2024
tedyu pushed a commit to tedyu/kafka that referenced this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-approved clients consumer small Small PRs tests Test fixes (including flaky tests)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants