Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-18000: Fix flaky ReplicaManagerTest#testSuccessfulBuildRemoteLo… #17887

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

mimaison
Copy link
Member

…gAuxStateMetrics

Use waitUntilTrue(), like we do in the other tests, to ensure the fetcher thread has time to run and tick the metrics after we call becomeLeaderOrFollower().

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@github-actions github-actions bot added core Kafka Broker tests Test fixes (including flaky tests) small Small PRs labels Nov 20, 2024
Copy link
Member

@mumrah mumrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @mimaison! LGTM

I kicked off another build just now. If that passes let's merge this

@mimaison
Copy link
Member Author

The rebuild was green, merging to trunk. Thanks

@mimaison mimaison merged commit 33318bc into apache:trunk Nov 22, 2024
8 checks passed
@mimaison mimaison deleted the kafka-18000 branch November 22, 2024 19:40
chiacyu pushed a commit to chiacyu/kafka that referenced this pull request Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Kafka Broker small Small PRs tests Test fixes (including flaky tests)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants