Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: Cleanups in raft module #17877

Merged
merged 1 commit into from
Nov 21, 2024
Merged

MINOR: Cleanups in raft module #17877

merged 1 commit into from
Nov 21, 2024

Conversation

mimaison
Copy link
Member

Mostly using the isEmpty() method of Optional.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@github-actions github-actions bot added the kraft label Nov 20, 2024
yashmayya
yashmayya approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@yashmayya yashmayya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the patch!

@mimaison mimaison merged commit c0a092f into apache:trunk Nov 21, 2024
8 checks passed
@mimaison mimaison deleted the cleanups-raft branch November 21, 2024 14:19
chiacyu pushed a commit to chiacyu/kafka that referenced this pull request Nov 30, 2024
@mimaison @chiacyu
MINOR: Cleanups in raft module (apache#17877)
31f3c58 
Reviewers: Yash Mayya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yashmayya yashmayya yashmayya approved these changes

Assignees
No one assigned
Labels
kraft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mimaison @yashmayya