Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-18045: Add 0.11, 1.0, 1.1, and 2.0 back to streams_upgrade_test.py #17876

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

KAFKA-18045: Add 0.11, 1.0, 1.1, and 2.0 back to streams_upgrade_test.py #17876

wants to merge 1 commit into from
+38 −3

Conversation

FrankYang0529
Copy link
Member

Add 0.11, 1.0, 1.1, and 2.0 back to align with stream compatibility matrix: https://kafka.apache.org/39/documentation/streams/upgrade-guide#streams_api_broker_compat

ref: #17843 (comment)

> TC_PATHS="tests/kafkatest/tests/streams/streams_upgrade_test.py" /bin/bash tests/docker/run_tests.sh
================================================================================
SESSION REPORT (ALL TESTS)
ducktape version: 0.12.0
session_id:       2024-11-20--002
run time:         58 minutes 30.640 seconds
tests run:        24
passed:           24
flaky:            0
failed:           0
ignored:          0
================================================================================

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@github-actions github-actions bot added tools small Small PRs labels Nov 20, 2024
chia7712
chia7712 reviewed Nov 20, 2024
View reviewed changes
Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FrankYang0529 thanks for this quick fix

tests/docker/Dockerfile
RUN mkdir -p "/opt/kafka-0.11.0.3" && chmod a+rw /opt/kafka-0.11.0.3 && curl -s "$KAFKA_MIRROR/kafka_2.11-0.11.0.3.tgz" | tar xz --strip-components=1 -C "/opt/kafka-0.11.0.3"
RUN mkdir -p "/opt/kafka-1.0.2" && chmod a+rw /opt/kafka-1.0.2 && curl -s "$KAFKA_MIRROR/kafka_2.11-1.0.2.tgz" | tar xz --strip-components=1 -C "/opt/kafka-1.0.2"
RUN mkdir -p "/opt/kafka-1.1.1" && chmod a+rw /opt/kafka-1.1.1 && curl -s "$KAFKA_MIRROR/kafka_2.11-1.1.1.tgz" | tar xz --strip-components=1 -C "/opt/kafka-1.1.1"
RUN mkdir -p "/opt/kafka-2.0.1" && chmod a+rw /opt/kafka-2.0.1 && curl -s "$KAFKA_MIRROR/kafka_2.12-2.0.1.tgz" | tar xz --strip-components=1 -C "/opt/kafka-2.0.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add comments to say "those old kafka are used to run client code so we don't need to handle the zookeeper issue"? see #17625 for the details

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated it. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chia7712 chia7712 Awaiting requested review from chia7712

Assignees
No one assigned
Labels
small Small PRs tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FrankYang0529 @chia7712