KAFKA-18039: Test all versions of quorum responses in RequestResponseTest #17873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modified createDescribeQuorumResponse, createEndQuorumEpochResponse, and createBeginQuorumEpochResponse methods to accept a version parameter. - Adjusted logic to set properties based on the version, ensuring compatibility with different response versions. - Added node endpoint handling for EndQuorumEpochResponse and BeginQuorumEpochResponse based on version checks.
github-actions
bot
added
tests
|
@ahuang98 Hi, This PR is ready, could you please take a look, thanks! |
ahuang98
approved these changes
Nov 26, 2024
| .setCurrentVoters(singletonList(replicaState)) | ||
| .setObservers(singletonList(replicaState)); | ||
| DescribeQuorumResponseData.TopicData topicData = new DescribeQuorumResponseData.TopicData() | ||
| .setTopicName("topic1") |
There was a problem hiding this comment.
nit: should we just make this __cluster_metadata
There was a problem hiding this comment.
@ahuang98 Thanks, fixed
… metadata topic name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following should support accepting
versionas they have more than one versionRelated links
Committer Checklist (excluded from commit message)