KAFKA-17898: Refine Epoch Bumping Logic #17849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jolshan
reviewed
Nov 18, 2024
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java
Outdated
Show resolved
Hide resolved
jolshan
reviewed
Nov 18, 2024
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java
Show resolved
Hide resolved
jolshan
reviewed
Nov 18, 2024
| * making errors abortable without manual intervention. | ||
| * | ||
| * - **Non-Transactional Producers**: | ||
| * For non-transactional producers, errors are considered abortable since no transaction rollback is necessary. |
There was a problem hiding this comment.
Hmm. This comment is a little confusing. I didn't think that idempotent producers had abortable errors. I think this method is only called from transactional apis.
There was a problem hiding this comment.
Oya that's an oversight on my part, since I added the condition !isTransactional and in these cases we set epochBumpRequired true and treat it as an abortable error I got confused
There was a problem hiding this comment.
Should we remove the !isTransactional condition too in this case?
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java
Outdated
Show resolved
Hide resolved
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java
Outdated
Show resolved
Hide resolved
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java
Outdated
Show resolved
Hide resolved
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java
Outdated
Show resolved
Hide resolved
jolshan
reviewed
Nov 22, 2024
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java
Outdated
Show resolved
Hide resolved
jolshan
reviewed
Nov 22, 2024
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java
Show resolved
Hide resolved
jolshan
reviewed
Nov 22, 2024
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java
Show resolved
Hide resolved
chiacyu
pushed a commit
to chiacyu/kafka
that referenced
this pull request
Nov 30, 2024
With KAFKA-14562, we implemented epoch bump on both the client and the server. Mentioned below are the different epoch bump scenarios we have on hand after enabled tv2 Non-Transactional Producers • Epoch bumping is always allowed. • Different code paths are used to handle epoch bumping. Transactional Producers No Epoch Bump Allowed • coordinatorSupportsBumpingEpoch = false when initPIDVersion < 3 or initPIDVersion = null. Client-Triggered Epoch Bump Allowed • coordinatorSupportsBumpingEpoch = true when initPIDVersion >= 3. • TransactionVersion2Enabled = false when endTxnVersion < 5. Only Server-Triggered Epoch Bump Allowed • TransactionVersion2Enabled = true and endTxnVersion >= 5. We want to refine the code and make it more structured to correctly handle epoch bumping in the above mentioned cases. The changes made in this patch are: Rename epochBumpRequired to epochBumpTriggerRequired to symbolize a manual epoch bump request from the client Modify canEpochBump method according to the above mentioned scenarios Reviewers: Artem Livshits <[email protected]>, Calvin Liu <[email protected]>, Justine Olshan <[email protected]>
tedyu
pushed a commit
to tedyu/kafka
that referenced
this pull request
Jan 6, 2025
With KAFKA-14562, we implemented epoch bump on both the client and the server. Mentioned below are the different epoch bump scenarios we have on hand after enabled tv2 Non-Transactional Producers • Epoch bumping is always allowed. • Different code paths are used to handle epoch bumping. Transactional Producers No Epoch Bump Allowed • coordinatorSupportsBumpingEpoch = false when initPIDVersion < 3 or initPIDVersion = null. Client-Triggered Epoch Bump Allowed • coordinatorSupportsBumpingEpoch = true when initPIDVersion >= 3. • TransactionVersion2Enabled = false when endTxnVersion < 5. Only Server-Triggered Epoch Bump Allowed • TransactionVersion2Enabled = true and endTxnVersion >= 5. We want to refine the code and make it more structured to correctly handle epoch bumping in the above mentioned cases. The changes made in this patch are: Rename epochBumpRequired to epochBumpTriggerRequired to symbolize a manual epoch bump request from the client Modify canEpochBump method according to the above mentioned scenarios Reviewers: Artem Livshits <[email protected]>, Calvin Liu <[email protected]>, Justine Olshan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With KAFKA-14562, we implemented epoch bump on both the client and the server. Mentioned below are the different epoch bump scenarios we have on hand after enabled tv2
Non-Transactional Producers
• Epoch bumping is always allowed.
• Different code paths are used to handle epoch bumping.
Transactional Producers
No Epoch Bump Allowed
• coordinatorSupportsBumpingEpoch = false when initPIDVersion < 3 or initPIDVersion = null.
Client-Triggered Epoch Bump Allowed
• coordinatorSupportsBumpingEpoch = true when initPIDVersion >= 3.
• TransactionVersion2Enabled = false when endTxnVersion < 5.
Only Server-Triggered Epoch Bump Allowed
• TransactionVersion2Enabled = true and endTxnVersion >= 5.
We want to refine the code and make it more structured to correctly handle epoch bumping in the above mentioned cases.
The changes made in this patch are: