[WIP] KIP-891: Connect Multiversion Support (Transformation and Predicate Changes) #17742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gharris1727
reviewed
Dec 13, 2024
|
Hi @gharris1727. I have updated the code a bit. PTAL and LMK if you have any queries. |
gharris1727
reviewed
Dec 17, 2024
| final ConfigDef.Validator typeValidator = ConfigDef.LambdaValidator.with( | ||
| (String name, Object value) -> { | ||
| validateProps(prefix); | ||
| // The value will be null if the class couldn't be found; no point in performing follow-up validation | ||
| if (value != null) { | ||
| getConfigDefFromConfigProvidingClass(typeConfig, (Class<?>) value); | ||
| getConfigDefFromPlugin(typeConfig, ((Class<?>) value).getName(), null, plugins); |
There was a problem hiding this comment.
I think this validator needs to include the error when the version is incorrect, similar to the converters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The is one of a set of PRs for KIP-891. The list of total PRs given below all build one the previous one in the list. They can be reviewed individually, or if the complete set of changes is preferrable, please refer to the last PR.
This is PR#3 and contains changes to support multiple versions of transformation and predicates with appropriate defaults and validations.
Committer Checklist (excluded from commit message)