Skip to content

KAFKA-17801: RemoteLogManager may compute inaccurate upperBoundOffset for aborted txns#17733

Merged
kamalcph merged 1 commit into
apache:3.9from
kamalcph:KAFKA-17801
Nov 10, 2024
Merged

KAFKA-17801: RemoteLogManager may compute inaccurate upperBoundOffset for aborted txns#17733
kamalcph merged 1 commit into
apache:3.9from
kamalcph:KAFKA-17801

Conversation

@kamalcph

@kamalcph kamalcph commented Nov 10, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

This is a cherry-pick of 324a74d commit

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@kamalcph
KAFKA-17801: RemoteLogManager may compute inaccurate upperBoundOffset…
4ce2f9b 
… for aborted txns (apache#17676)

Reviewers: Jun Rao <junrao@gmail.com>
@kamalcph
kamalcph requested review from chia7712 and junrao November 10, 2024 03:02
junrao
junrao reviewed Nov 10, 2024
View reviewed changes

@junrao junrao left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kamalcph : Thanks for the PR. The code LGTM. Are the test failures related?

@kamalcph

kamalcph commented Nov 10, 2024

Copy link
Copy Markdown
Contributor Author

@kamalcph : Thanks for the PR. The code LGTM. Are the test failures related?

Test failures are unrelated. There were 1 flaky TransactionsWithTieredStoreTest, ensured that it passes locally:

Gradle Test Run :storage:test > Gradle Test Executor 1 > TransactionsWithTieredStoreTest > testInitTransactionsTimeout(String) > "testInitTransactionsTimeout(String).quorum=zk" PASSED
Gradle Test Run :storage:test > Gradle Test Executor 1 > TransactionsWithTieredStoreTest > testInitTransactionsTimeout(String) > "testInitTransactionsTimeout(String).quorum=kraft" PASSED
Gradle Test Run :storage:test > Gradle Test Executor 1 > TransactionsWithTieredStoreTest > testInitTransactionsTimeout(String) > "testInitTransactionsTimeout(String).quorum=kraft+kip848" PASSED

junrao
junrao approved these changes Nov 10, 2024
View reviewed changes

@junrao junrao left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kamalcph : Thanks for triaging the tests. LGTM

@kamalcph
kamalcph merged commit 6ea2ed3 into apache:3.9 Nov 10, 2024
@kamalcph
kamalcph deleted the KAFKA-17801 branch November 11, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@junrao junrao junrao approved these changes
@chia7712 chia7712 Awaiting requested review from chia7712

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kamalcph @junrao