Skip to content

MINOR: Cleanup GroupCoordinatorRecordHelpers #17718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chia7712 merged 1 commit into from
Nov 8, 2024
Merged

MINOR: Cleanup GroupCoordinatorRecordHelpers #17718

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 3 additions & 32 deletions ...nator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorRecordHelpers.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,35 +360,6 @@ public static CoordinatorRecord newConsumerGroupCurrentAssignmentRecord(
);
}

/**
* Creates a ConsumerGroupCurrentMemberAssignment record.
*
* @param groupId The consumer group id.
* @param member The share group member.
* @return The record.
*/
public static CoordinatorRecord newConsumerGroupCurrentAssignmentRecord(
String groupId,
ShareGroupMember member
) {
return new CoordinatorRecord(
new ApiMessageAndVersion(
new ConsumerGroupCurrentMemberAssignmentKey()
.setGroupId(groupId)
.setMemberId(member.memberId()),
(short) 8
),
new ApiMessageAndVersion(
new ConsumerGroupCurrentMemberAssignmentValue()
.setMemberEpoch(member.memberEpoch())
.setPreviousMemberEpoch(member.previousMemberEpoch())
.setState(member.state().value())
.setAssignedPartitions(toTopicPartitions(member.assignedPartitions())),
(short) 0
)
);
}

/**
* Creates a ConsumerGroupCurrentMemberAssignment tombstone.
*
Expand Down Expand Up @@ -731,7 +702,7 @@ public static CoordinatorRecord newShareGroupSubscriptionMetadataRecord(
* @return The record.
*/
public static CoordinatorRecord newShareGroupSubscriptionMetadataTombstoneRecord(
String groupId
String groupId
) {
return new CoordinatorRecord(
new ApiMessageAndVersion(
Expand Down Expand Up @@ -929,8 +900,8 @@ public static CoordinatorRecord newShareGroupCurrentAssignmentRecord(
* @return The record.
*/
public static CoordinatorRecord newShareGroupCurrentAssignmentTombstoneRecord(
String groupId,
String memberId
String groupId,
String memberId
) {
return new CoordinatorRecord(
new ApiMessageAndVersion(
Expand Down