KAFKA-2072: Add StopReplica request/response to o.a.k.common.requests#170
Closed
dajac wants to merge 4 commits into
Closed
KAFKA-2072: Add StopReplica request/response to o.a.k.common.requests#170dajac wants to merge 4 commits into
dajac wants to merge 4 commits into
Conversation
|
kafka-trunk-git-pr #222 FAILURE |
Member
Author
|
Failure is not related to this one. |
|
kafka-trunk-git-pr #224 SUCCESS |
|
kafka-trunk-git-pr #225 FAILURE |
…er defined in the protocol.
|
kafka-trunk-git-pr #227 SUCCESS |
Member
Author
|
@ijuma Thank you for the review. I think that I have addressed most of your comments. |
Member
|
LGTM. As this doesn't change any running code, it's low-risk. |
Contributor
|
Thanks for the patch. LGTM. |
maxzheng
pushed a commit
to maxzheng/kafka
that referenced
this pull request
Jul 31, 2018
This is a cherry-pick from 1.1 to 2.0 as KIP-91 will only land in a future feature release. We solve the problem of expired batches not being retried by providing the a separate config `confluent.batch.expiry.ms` which controls how long to wait before batches are expired. Before this patch, we would expire batches once `request.timeout.ms` elapsed. By setting the new config value to be very high, we ensure that batches are never expired, which has the same effect as being retried indefinitely.
jsancio
pushed a commit
to jsancio/kafka
that referenced
this pull request
Aug 6, 2019
…he#170) There is a problem in our current setup that prevents the Docker images from cc-services to build in CI. This is a regression from commit f6e5c51 (https://github.com/confluentinc/ce-kafka/commit/f6e5c51c2522e061bc523cddbd2795c0bdd9129c) We wanted to automatically build the cc-services in CI via the "make build" command. Due to our makefiles having conditional logic depending on whether they are running in CI and whether they are running the main branch (ce-trunk), we did not catch this issue during testing. We are removing the automatic built of the cc-services in the main makefile by removing the override on the build docker targets. Reviewers: Stanislav <stanislav@confluent.io>
patrik-marton
pushed a commit
to patrik-marton/kafka
that referenced
this pull request
Mar 11, 2025
davide-armand
pushed a commit
to aiven/kafka
that referenced
this pull request
Dec 1, 2025
* refactor(inkless:file_cleaner): add backoff/jitter Similar to file merger, add jitter to minimize concurrent executions. * test(inkless): add minio testcontainer There are certain limits that are not available on localstack. Adding Minio container for more realistic tests. * fix(inkless:s3): batch delete keys by 1000 refactor(inkless): close shared state chore(inkless): reduce iterations for lower memory usage After adding another integration test, infinispan started to run OOM
fvaleri
added a commit
to fvaleri/kafka
that referenced
this pull request
May 20, 2026
* Add Cluster Mirroring system tests I finally found some time to dump the bash system tests collected so far into proper Kafka system test, integrating the two that we already had. At this point, I think that we absolutely need a complete test suite because every change risks to break something else and we only find out much later. We now have 15 system tests that cover most of the features. I also plan to add at least one additional test for secure mirror configuration and one or two for the migration use case, but I need more time. Please have a look and help me to make them better. Thanks. Signed-off-by: Federico Valeri <fedevaleri@gmail.com> * Address comments Signed-off-by: Federico Valeri <fedevaleri@gmail.com> * Add cluster mirroring secure system test Signed-off-by: Federico Valeri <fedevaleri@gmail.com> * Fix secure tests flakiness Signed-off-by: Federico Valeri <fedevaleri@gmail.com> * Update with latest refactorings Signed-off-by: Federico Valeri <fedevaleri@gmail.com> * Add migration tests Signed-off-by: Federico Valeri <fedevaleri@gmail.com> * Add migration tests fixes Signed-off-by: Federico Valeri <fedevaleri@gmail.com> * Re-enable the test Signed-off-by: Federico Valeri <fedevaleri@gmail.com> * Add few improvements Signed-off-by: Federico Valeri <fedevaleri@gmail.com> * And not or Signed-off-by: Federico Valeri <fedevaleri@gmail.com> --------- Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds StopReplica request and response as it is required by @ijuma for KAFKA-2411. Migration of core module is addressed a separate PR (#141).
@ijuma Could you review it? @gwenshap Could you take a look as well?