MINOR: Await consumer group membership before verifying/modifying sink connector offsets in OffsetsApiIntegrationTest #16519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've filed #16551 to run every affected test case 5 times each. |
…ink connector offsets in OffsetsApiIntegrationTest
C0urante
force-pushed
the
offsets-api-integration-test-wait-for-consumer-groups
branch
from
9d73236
to
660da5c
Compare
C0urante
changed the title
C0urante
changed the title
C0urante
changed the title
C0urante
commented
Jul 9, 2024
| * @throws InterruptedException if the thread is interrupted while waiting for the consumer | ||
| * group to form | ||
| */ | ||
| private void verifyConsumerGroupMembers( |
There was a problem hiding this comment.
TODO: If this method is useful, it will obviate the existing modifySinkConnectorOffsetsWithRetry method, which we will then be able to remove.
C0urante
force-pushed
the
offsets-api-integration-test-wait-for-consumer-groups
branch
from
e3c4bfe
to
1c443c4
Compare
|
It seems like there's a real consumer bug that's been causing this flakiness: https://issues.apache.org/jira/browse/KAFKA-17115 Closing this PR in favor of the bug fix. |
C0urante
deleted the
offsets-api-integration-test-wait-for-consumer-groups
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft; will flesh out description if this yields positive results.
Committer Checklist (excluded from commit message)