Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-16584 Make log processing summary configurable or debug #16509

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

dujian0068
Copy link
Contributor

KAFKA-16584 Make log processing summary configurable or debug

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

Make log processing summary configurable or debug
@mjsax mjsax added streams kip Requires or implements a KIP labels Jul 9, 2024
@mjsax mjsax requested a review from bbejeck July 9, 2024 05:24
@mjsax
Copy link
Member

mjsax commented Jul 9, 2024

Please don't forget to update the docs (upgrade guide and configs sections).

@mjsax
Copy link
Member

mjsax commented Jul 9, 2024

@dujian0068 -- you should send a final email to the VOTE thread calling the vote closed and accepted (also summarizing the vote result), and update the KIP wiki pages accordingly. Thanks.

@dujian0068
Copy link
Contributor Author

dujian0068 commented Jul 10, 2024

Please don't forget to update the docs (upgrade guide and configs sections).

@mjsax Thank you review:
Do you mean the documentation that needs to be updated is in the https://github.com/apache/kafka-site project?

@mjsax
Copy link
Member

mjsax commented Jul 10, 2024

No. The doc changes just go into kafka.git as part of this PR -> https://github.com/apache/kafka/tree/trunk/docs/streams

kafka-site.git will only be updated during the next release -- you don't have to worry about this part.

Copy link
Contributor

@bbejeck bbejeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the KIP and contribution @dujian0068!

Overall this looks good, I have one minor comment.

Make log processing summary configurable or debug
Make log processing summary configurable or debug
@dujian0068
Copy link
Contributor Author

Thank you @mjsax
I have updated config-stream doc. Do I need to update upgrade-guide? Can you tell me in which cases I need to update upgrade-guide?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kip Requires or implements a KIP streams
Projects
None yet
3 participants