MINOR; Fix incompatible change to the kafka config #16464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsancio
changed the title
cmccabe
approved these changes
Jun 27, 2024
omkreddy
added a commit
to confluentinc/kafka
that referenced
this pull request
Jun 28, 2024
…#1350) Fix compilation failures due to upstream change : apache#16464
abhi-ksolves
pushed a commit
to ksolves/kafka
that referenced
this pull request
Jul 31, 2024
Prior to KIP-853, users were not allow to enumerate listeners specified in `controller.listener.names` in the `advertised.listeners`. This decision was made in 3.3 because the `controller.quorum.voters` property is in effect the list of advertised listeners for all of the controllers. KIP-853 is moving away from `controller.quorum.voters` in favor of a dynamic set of voters. This means that the user needs to have a way of specifying the advertised listeners for controller. This change allows the users to specify listener names in `controller.listener.names` in `advertised.listeners`. To make this change forwards compatible (use a valid configuration from 3.8 in 3.9), the controller's advertised listeners are going to get computed by looking up the endpoint in `advertised.listeners`. If it doesn't exist, the controller will look up the endpoint in the `listeners` configuration. This change also includes a fix the to the BeginQuorumEpoch request where the default value for VoterId was 0 instead of -1. Reviewers: Colin P. McCabe <[email protected]>
|
Warning: the fallback works only if the CONTROLLER listener host is routable, e.g. not for |
emasab
added a commit
to confluentinc/librdkafka
that referenced
this pull request
Dec 13, 2024
Mock handler implementation Rename current consumer protocol from generic to classic Mock handler with automatic or manual assignment More consumer group metadata getters Test helpers Configurable session timeout and HB interval Fix mock handler ListOffsets response LeaderEpoch instead of CurrentLeaderEpoch Integration tests passing with AK trunk Improve documentation and KIP 848 specific mock tests Add mock tests for unknown topic id in metadata request and partial reconciliation Make test 0147 more reliable Fix test 0106 after HB timeout change Exclude test case with AK trunk Rename rd_kafka_buf_write_tags to rd_kafka_buf_write_tags_empty Trivup 0.12.5 can run a KafkaCluster directly with KRaft and AK trunk Trivup 0.12.6 build with a specific commit Trivup 0.12.7 with fixes for AK 3.8.0 and Py 3.12 New version of trivup 0.12.7 to fix an issue with apache/kafka#16464 on AK > 3.8.0 Static group membership mock tests Move test 0147 to a different PR Disable interactive "needsrestart" prompt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to KIP-853, users were not allow to enumerate listeners specified in
controller.listener.namesin theadvertised.listeners. This decision was made in 3.3 because thecontroller.quorum.votersproperty is in effect the list of advertised listeners for all of the controllers.KIP-853 is moving away from
controller.quorum.votersin favor of a dynamic set of voters. This means that the user needs to have a way of specifying the advertised listeners for controller.This change allows the users to specify listener names in
controller.listener.namesinadvertised.listeners. To make this change forwards compatible (use a valid configuration from 3.8 in 3.9), the controller's advertised listeners are going to get computed by looking up the endpoint inadvertised.listeners. If it doesn't exist, the controller will look up the endpoint in thelistenersconfiguration.This change also includes a fix the to the BeginQuorumEpoch request where the default value for VoterId was 0 instead of -1.
Committer Checklist (excluded from commit message)