Skip to content

KAFKA-2462: allow modifying soft limit for open files in Kafka startup script #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gwenshap wants to merge 1 commit into from
Closed

KAFKA-2462: allow modifying soft limit for open files in Kafka startup script #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions bin/kafka-run-class.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,10 @@ while [ $# -gt 0 ]; do
DAEMON_MODE="true"
shift
;;
--soft-file-limit)
ulimit -n $2
shift 2
;;
*)
break
;;
Expand Down
6 changes: 5 additions & 1 deletion bin/kafka-server-start.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

if [ $# -lt 1 ];
then
echo "USAGE: $0 [-daemon] server.properties [--override property=value]*"
echo "USAGE: $0 [-daemon] [--soft-file-limit number] server.properties [--override property=value]*"

@SinghAsDev SinghAsDev Aug 24, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, if it would make sense to have it as part of kafka-env.sh, as suggested in KAFKA-1566?

exit 1
fi
base_dir=$(dirname $0)
Expand All @@ -37,6 +37,10 @@ case $COMMAND in
EXTRA_ARGS="-daemon "$EXTRA_ARGS
shift
;;
--soft-file-limit)

@ewencp ewencp Aug 24, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this doesn't work if you provide them in the reverse order (i.e., --soft-file-limit <number> -daemon, which I would assume would be possible)? I think you'd need a while loop around this.

EXTRA_ARGS="--soft-file-limit ${2} "$EXTRA_ARGS
shift 2
;;
*)
;;
esac
Expand Down