Skip to content
Closed
Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
b9499c2
Changed toString() override to toStringBase()
brenden20 May 24, 2024
58f1ca4
Added test for toStringBase()
brenden20 May 24, 2024
7a5f172
Added to toStringBase()
brenden20 May 24, 2024
4f56809
Add println and example hashcode
brenden20 May 24, 2024
1dea30d
Edited toStringBase test
brenden20 May 28, 2024
cee03b7
Added to toStringBase and updated test
brenden20 May 28, 2024
42c7826
Remove hashcode comment
brenden20 May 28, 2024
935f0b8
Add testing comment
brenden20 May 29, 2024
272d5de
Updated toStringBase and added toString
brenden20 May 29, 2024
7aa6ba5
Remove debugging print
brenden20 May 30, 2024
f5a3748
Merge branch 'apache:trunk' into 16557
brenden20 May 31, 2024
b560db3
Implementing PR suggestions
brenden20 Jun 3, 2024
8d7ddbb
Fixed build error
brenden20 Jun 3, 2024
3d9f58b
Small changes to testOffsetFetchRequestStateToStringBase()
brenden20 Jun 3, 2024
426313a
Remove debug print
brenden20 Jun 3, 2024
4461145
Whitespace fixes
brenden20 Jun 3, 2024
a252ec1
More whitespace changes
brenden20 Jun 3, 2024
33a7748
Fix style
brenden20 Jun 3, 2024
554ad53
Updated testOffsetFetchRequestStateToStringBase()
brenden20 Jun 3, 2024
f5abcc5
Merge branch 'apache:trunk' into 16557
brenden20 Jun 3, 2024
7e8be50
Revert "Merge branch 'apache:trunk' into 16557"
brenden20 Jun 3, 2024
97c29c6
Updated testOffsetFetchRequestStateToStringBase()
brenden20 Jun 10, 2024
df3e2ae
Revert "Updated testOffsetFetchRequestStateToStringBase()"
brenden20 Jun 10, 2024
c34f473
Merge branch 'trunk' into 16557
brenden20 Jun 10, 2024
9265258
Merge branch 'apache:trunk' into 16557
brenden20 Jun 11, 2024
74034dc
Revert "Merge branch 'trunk' into 16557"
brenden20 Jun 10, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -880,6 +880,11 @@ boolean retryTimeoutExpired(long currentTimeMs) {
}

abstract void removeRequest();

Comment thread
brenden20 marked this conversation as resolved.
// Visible for testing
protected Optional<Long> expirationTimeMs() {
return expirationTimeMs;
}
}

class OffsetFetchRequestState extends RetriableRequestState {
Expand Down Expand Up @@ -1090,14 +1095,13 @@ private void chainFuture(
}

@Override
public String toString() {
return "OffsetFetchRequestState{" +
"requestedPartitions=" + requestedPartitions +
", memberId=" + memberInfo.memberId.orElse("undefined") +
", memberEpoch=" + (memberInfo.memberEpoch.isPresent() ? memberInfo.memberEpoch.get() : "undefined") +
", future=" + future +
", " + toStringBase() +
'}';
public String toStringBase() {
return super.toStringBase() +
", memberInfo=" + memberInfo +
", expirationTimeMs=" + (expirationTimeMs().isPresent() ? expirationTimeMs() : "undefined") +
", isExpired=" + isExpired +
", requestedPartitions=" + requestedPartitions +
", future=" + future;
}
}

Expand Down Expand Up @@ -1289,5 +1293,11 @@ static class MemberInfo {
this.memberId = Optional.empty();
this.memberEpoch = Optional.empty();
}

@Override
public String toString() {
Comment thread
brenden20 marked this conversation as resolved.
return "MemberInfo{" + "memberId=" + memberId.orElse("undefined") +
", memberEpoch=" + (memberEpoch.isPresent() ? memberEpoch : "undefined") + "}";
}
}
}
Loading