KAFKA-17069: Remote copy throttle metrics#16086
Merged
Merged
Conversation
abhijeetk88
marked this pull request as draft
May 27, 2024 06:07
gharris1727
added
kip
abhijeetk88
force-pushed
the
KAFKA-15434_copy_quota_metrics
branch
from
June 9, 2024 08:04
6b2c9b0 to
69a2e93
Compare
abhijeetk88
marked this pull request as ready for review
June 9, 2024 08:08
abhijeetk88
force-pushed
the
KAFKA-15434_copy_quota_metrics
branch
from
June 12, 2024 06:49
69a2e93 to
4d5de93
Compare
Contributor
|
Can you resolve the conflicts on this PR? |
abhijeetk88
force-pushed
the
KAFKA-15434_copy_quota_metrics
branch
from
June 12, 2024 14:48
4d5de93 to
6652e29
Compare
showuon
reviewed
Jun 21, 2024
showuon
left a comment
showuon
left a comment
Member
There was a problem hiding this comment.
Left some comments. Like the other PR, could we add some tests to verify the real metrics are updated correctly? Something like RemoteLogManagerTest#assertCopyExpectedLogSegmentsToRemote or ReplicaManagerTest#testRemoteLogReaderMetrics test. Thanks.
abhijeetk88
force-pushed
the
KAFKA-15434_copy_quota_metrics
branch
from
July 2, 2024 11:30
6652e29 to
90c68a5
Compare
abhijeetk88
force-pushed
the
KAFKA-15434_copy_quota_metrics
branch
from
July 3, 2024 08:53
90c68a5 to
f99c139
Compare
abhijeetk88
changed the title
Contributor
Author
|
@showuon I have updated the PR. Please take another look. |
kamalcph
approved these changes
Jul 3, 2024
satishd
approved these changes
Jul 3, 2024
satishd
left a comment
satishd
left a comment
Member
There was a problem hiding this comment.
Thanks @abhijeetk88 for the PR. LGTM.
Member
|
Failed tests are unrelated. |
abhi-ksolves
pushed a commit
to ksolves/kafka
that referenced
this pull request
Jul 31, 2024
As part of KIP-956, we have added quota for remote copies to remote storage. In this PR, we are adding the following metrics for remote copy throttling. 1. remote-copy-throttle-time-avg The average time in millis remote copies was throttled by a broker 2. remote-copy-throttle-time-max The max time in millis remote copies was throttled by a broker Added unit test for the metrics. Reviewers: Kamal Chandraprakash<kamal.chandraprakash@gmail.com>, Luke Chen <showuon@gmail.com>, Satish Duggana <satishd@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of KIP-956, we have added quota for remote copies to remote storage. In this PR, we are adding the following metrics for remote copy throttling.
Added unit test for the metrics.
I will have a follow-up PR to add these metrics to Kafka documentation.
Committer Checklist (excluded from commit message)