Skip to content

MINOR: Make Checkstyle more strict, restore global code quality checks to 2018 #15367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gharris1727 wants to merge 31 commits into from
Closed

MINOR: Make Checkstyle more strict, restore global code quality checks to 2018 #15367

Show file tree
Hide file tree
Changes from 28 commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
9b0b94a
MINOR: Revert global checkstyle metrics configuration to 2018
gharris1727 Feb 13, 2024
5232ff9
Add suppressions for classes with MethodLength warnings
gharris1727 Feb 16, 2024
cc4992e
Remove duplicate suppressions
gharris1727 Feb 16, 2024
73104de
fixup: remove duplicate Murmur3
gharris1727 Feb 16, 2024
aff8a8c
Normalize check names
gharris1727 Feb 16, 2024
e1d7996
Normalize some suppressions
gharris1727 Feb 16, 2024
dee15f8
system exit
gharris1727 Feb 16, 2024
a5d8254
class data abstraction coupling
gharris1727 Feb 16, 2024
1071b38
boolean expression
gharris1727 Feb 16, 2024
ef1b15f
static variable name
gharris1727 Feb 16, 2024
cfb3b7e
class fan out complexity
gharris1727 Feb 16, 2024
c1df43b
parameter number
gharris1727 Feb 16, 2024
0bb3079
ncss
gharris1727 Feb 16, 2024
3ce6b5b
cyclomatic complexity
gharris1727 Feb 16, 2024
43d57ae
npath complexity
gharris1727 Feb 16, 2024
d6eae5a
method length
gharris1727 Feb 16, 2024
c4768a9
import control
gharris1727 Feb 16, 2024
38d1f53
whitespace, local variable name, import control
gharris1727 Feb 16, 2024
16532c8
npath complexity and cyclomatic complexity
gharris1727 Feb 16, 2024
3e82558
npath complexity, import control, illegal import
gharris1727 Feb 16, 2024
f7ad3e7
cyclomatic complexity, method length, ncss
gharris1727 Feb 16, 2024
383a67d
npath complexity and method length
gharris1727 Feb 16, 2024
b4257c5
data abstraction coupling, npath complexity, method length
gharris1727 Feb 16, 2024
6a68eea
Add suppressions for classes that were covered by other suppressions
gharris1727 Feb 16, 2024
e8787ab
Add checkstyle_audit.py that verifies that global checkstyle suppress…
gharris1727 Feb 16, 2024
2cf923a
Merge remote-tracking branch 'upstream/trunk' into minor-cleanup-supp…
gharris1727 Mar 4, 2024
d9585e1
fixup: IQv2IntegrationTest MethodLength suppression
gharris1727 Mar 6, 2024
48102b6
Merge remote-tracking branch 'upstream/trunk' into minor-cleanup-supp…
gharris1727 Mar 13, 2024
218696b
Merge remote-tracking branch 'upstream/trunk' into minor-cleanup-supp…
gharris1727 Mar 25, 2024
02a2874
Merge remote-tracking branch 'upstream/trunk' into minor-cleanup-supp…
gharris1727 Mar 29, 2024
7a323d2
Remove extra suppressions, fix streams/test-utils main code path check
gharris1727 Mar 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions checkstyle/checkstyle.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@

<!-- code quality -->
<module name="MethodLength">
<property name="max" value="170" />
<!-- default is 150 -->
</module>
<module name="ParameterNumber">
<!-- default is 8 -->
Expand All @@ -131,7 +131,7 @@

<module name="ClassFanOutComplexity">
<!-- default is 20 -->
<property name="max" value="52"/>
<property name="max" value="50"/>
</module>
<module name="CyclomaticComplexity">
<!-- default is 10-->
Expand Down
Loading