Skip to content

KAFKA-16202: Extra dot in error message in producer #15296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chia7712 merged 6 commits into from
Mar 7, 2024
Merged

KAFKA-16202: Extra dot in error message in producer #15296

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ec84fa3
Omit a dot in the complete error message
infantlikesprogramming Jan 31, 2024
1e21dde
Merge branch 'trunk' into producer-error-message-StorageError
infantlikesprogramming Feb 1, 2024
07e3a63
Merge branch 'apache:trunk' into producer-error-message-StorageError
infantlikesprogramming Feb 9, 2024
891977b
add code to make appropriate change to the error message in case it e…
infantlikesprogramming Feb 9, 2024
39b64da
Editted log message to simply code. Added dots to "defaultExceptionSt…
infantlikesprogramming Feb 16, 2024
847f2bb
Merge branch 'apache:trunk' into producer-error-message-StorageError
infantlikesprogramming Feb 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -704,7 +704,7 @@ private void completeBatch(ProducerBatch batch, ProduceResponse.PartitionRespons
"topic-partition may not exist or the user may not have Describe access to it",
batch.topicPartition);
} else {
log.warn("Received invalid metadata error in produce request on partition {} due to {}. Going " +
log.warn("Received invalid metadata error in produce request on partition {} due to {} Going " +
"to request metadata update now", batch.topicPartition,

@appchemist appchemist Feb 6, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some error have dot, while others don't.
So, When dot is absent, there is no dot before 'Going'.

See Errors.INCONSISTENT_TOPIC_ID for details.

@infantlikesprogramming infantlikesprogramming Feb 9, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your comment. I have made changes based on your review in the latest (4th) commit.

@appchemist appchemist Feb 10, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about including dot in Errors's defaultExceptionString that don't currently include dot?
I referred to Use grammatically correct error messages.
In addition, most Errors's defaultExceptionString already include dot.

@infantlikesprogramming infantlikesprogramming Feb 16, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes a lot of sense. Thank you so much @appchemist. It took me a while to understand the code. I will fix this in my next commit.

error.exception(response.errorMessage).toString());
}
Expand Down