Skip to content

MINOR: Log the ZK dual-write time #14792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mumrah wants to merge 1 commit into from
+9 −3
Closed

MINOR: Log the ZK dual-write time #14792

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,21 +518,27 @@ public void run() throws Exception {

Map<String, Integer> dualWriteCounts = new TreeMap<>();
long startTime = time.nanoseconds();
final long zkWriteTimeMs;
if (isSnapshot) {
zkMetadataWriter.handleSnapshot(image, countingOperationConsumer(
dualWriteCounts, KRaftMigrationDriver.this::applyMigrationOperation));
controllerMetrics.updateZkWriteSnapshotTimeMs(NANOSECONDS.toMillis(time.nanoseconds() - startTime));
zkWriteTimeMs = NANOSECONDS.toMillis(time.nanoseconds() - startTime);
controllerMetrics.updateZkWriteSnapshotTimeMs(zkWriteTimeMs);
} else {
if (zkMetadataWriter.handleDelta(prevImage, image, delta, countingOperationConsumer(
dualWriteCounts, KRaftMigrationDriver.this::applyMigrationOperation))) {
// Only record delta write time if we changed something. Otherwise, no-op records will skew timings.
controllerMetrics.updateZkWriteDeltaTimeMs(NANOSECONDS.toMillis(time.nanoseconds() - startTime));
zkWriteTimeMs = NANOSECONDS.toMillis(time.nanoseconds() - startTime);
controllerMetrics.updateZkWriteDeltaTimeMs(zkWriteTimeMs);
} else {
zkWriteTimeMs = 0;
}
}
if (dualWriteCounts.isEmpty()) {
log.trace("Did not make any ZK writes when handling KRaft {}", isSnapshot ? "snapshot" : "delta");
} else {
log.debug("Made the following ZK writes when handling KRaft {}: {}", isSnapshot ? "snapshot" : "delta", dualWriteCounts);
log.debug("Made the following ZK writes in {} ms when handling KRaft {}: {}",

@chia7712 chia7712 Mar 4, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add same change for full snapshot sync ? https://github.com/apache/kafka/blob/trunk/metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java#L762

zkWriteTimeMs, isSnapshot ? "snapshot" : "delta", dualWriteCounts);
}

// Persist the offset of the metadata that was written to ZK
Expand Down