KAFKA-15664: Add 3.4 Streams upgrade system tests#14601
Merged
Conversation
This was referenced Oct 21, 2023
Member
Author
|
@mjsax It looks much better now. I ran the Streams system tests with this PR and just got a few flaky failures. All tests passed at least once in "only" 2 runs. |
showuon
approved these changes
Oct 23, 2023
mjsax
approved these changes
Oct 23, 2023
mjsax
left a comment
mjsax
left a comment
Member
There was a problem hiding this comment.
Nice! Thanks a ton! LGTM.
Should we trigger a system test run on this branch before merging?
Member
Author
|
When I ran the Streams system tests in our CI I used this branch, so merging to trunk. |
mimaison
added a commit
to mimaison/kafka
that referenced
this pull request
Oct 23, 2023
Reviewers: Luke Chen <showuon@gmail.com>, Matthias J. Sax <mjsax@apache.org>
mimaison
added a commit
to mimaison/kafka
that referenced
this pull request
Oct 23, 2023
Reviewers: Luke Chen <showuon@gmail.com>, Matthias J. Sax <mjsax@apache.org>
Member
Author
|
Backported to 3.5 and 3.6 Running the system tests on 3.4, then I'll backport to 3.4 too |
mimaison
added a commit
that referenced
this pull request
Oct 23, 2023
Reviewers: Luke Chen <showuon@gmail.com>, Matthias J. Sax <mjsax@apache.org>
Member
|
We don't need to backported to |
Member
Author
|
Ah ok, thanks for clarifying. |
mjsax
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Nov 22, 2023
Reviewers: Luke Chen <showuon@gmail.com>, Matthias J. Sax <mjsax@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted the 3.4 changes from #13860
Committer Checklist (excluded from commit message)