-
Notifications
You must be signed in to change notification settings - Fork 15.4k
KAFKA-14274 [6, 7]: Introduction of fetch request manager #14406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
junrao
merged 77 commits into
apache:trunk
from
kirktrue:KAFKA-14274-3-introduce-fetch-request-manager-take-2
Oct 24, 2023
Merged
Changes from 70 commits
Commits
Show all changes
77 commits
Select commit
Hold shift + click to select a range
a8bdc7b
KAFKA-14274 [6, 7]: Introduction of fetch request manager
kirktrue 7ab56f2
Reverted change to make FetchCollector.collectFetch() not take a Dese…
kirktrue 772ff2e
KAFKA-14274 [6, 7]: Introduction of fetch request manager
kirktrue a30ac4e
Reverted change to make FetchCollector.collectFetch() not take a Dese…
kirktrue 72b6b27
Post-rebase clean up
kirktrue ba9f0ff
Merge branch 'KAFKA-14274-3-introduce-fetch-request-manager-take-2' o…
kirktrue 7c8b945
Update NetworkClientDelegate.java
kirktrue 59d0daf
Minor clean up and refactoring based on first pass of reviews
kirktrue 5eef0f7
Medium-sized refactor of the queue processing
kirktrue 0457117
Merge branch 'trunk' into KAFKA-14274-3-introduce-fetch-request-manag…
kirktrue 1e18f98
Changes to PrototypeAsyncConsumer.close()
kirktrue 4a9cdd0
Updates to the fetch results/buffering process
kirktrue c873463
Updates for background event handler
kirktrue e8b990f
Minor refactoring for the event processor callbacks
kirktrue 731e716
Added comment to explain a case in DefaultBackgroundThread.wakeup()
kirktrue 3f92079
Closing the fetch sessions
kirktrue e08d01a
Minor logic change for assignFromUserNoId
kirktrue d7c4d0c
Minor logic change for assignFromUserNoId (from FetchRequestManagerTest)
kirktrue 6ffb7ec
Removed unnecessary references to "this" in fetcher tests
kirktrue 81c0c7e
Renamed FetchRequestManagerTest's consumerClient to networkClientDele…
kirktrue 7674304
Removed FetchRequestManagerTest's oldConsumerClient
kirktrue 0cbb8d2
Updated comment placement in old and new fetcher tests
kirktrue 9c7b4c4
Added documentation to RequestManager methods and referenced from Fet…
kirktrue 65197a1
Refactored AbstractFetch to make fetch request maps more succinct
kirktrue 5387b7f
Removed unnecessary "this" references.
kirktrue 8490681
Minor formatting change in beginningOrEndOffset
kirktrue 4e463d2
Revised usage of Timer in DefaultBackgroundThread.runAtClose()
kirktrue d3e920d
Got fed up and changed DefaultBackgroundThread to ConsumerNetworkThread
kirktrue 60470ed
Asserting ConsumerNetworkThread is not closed on each call to runOnce()
kirktrue 6c1004f
Clean up of outdated comments for BackgroundEventProcessor.process()
kirktrue 8497558
Clean up of logging, but a lot of other refactoring to reduce boilerp…
kirktrue 6338733
Removed now unneeded BackgroundEventHandler from FetchRequestManager
kirktrue 634e15b
Turned down the logging level in a couple of places
kirktrue 5f9aa58
Removed comment about wakeups from poll() (filed KAFKA-15555 to handle)
kirktrue 193af82
Fixed comment in assign() method
kirktrue cda5741
Made FetchBuffer thread safe so that it can be shared by application …
kirktrue 0d56cac
Minor: removed unnecessarily qualified reference to object from withi…
kirktrue f4fac21
Merge remote-tracking branch 'upstream/trunk' into KAFKA-14274-3-intr…
kirktrue 17458c4
Resolving merge conflicts with changes to trunk
kirktrue 281f28c
Removed assertion from ConsumerNetworkThread.runOnce to avoid logging
kirktrue 15738bd
Updated the fetch response handler method names for clarity
kirktrue 24e014f
ApplicationEventProcessor will now NOT throw errors on event processi…
kirktrue 2eaca7e
Removed redundant tests from ConsumerNetworkThreadTest
kirktrue d2ab01e
Now issuing both the poll() and pollOnClose() network I/O on the Cons…
kirktrue 19327fa
Fixed minor whitespace checkstyle violation in ConsumerNetworkThreadTest
kirktrue 621fc7d
Fixed typo in RequestManager comment
kirktrue bc3102f
Merge remote-tracking branch 'upstream/trunk' into KAFKA-14274-3-intr…
kirktrue 5a80371
Comments change to remove close() method in testFetcherCloseClosesFet…
kirktrue 2ba9e85
Removed superfluous poll() from testFetcherCloseClosesFetchSessionsIn…
kirktrue 627624c
Updated method names in FetcherTest and FetchRequestManagerTest
kirktrue 6ebd657
Changed locally-scoped "records" to "testRecords" to avoid naming col…
kirktrue e971901
Grammar fixes for comments in fetch tests
kirktrue 97d833e
Removed unnecessary fetchRecords call from testPartialFetchWithPaused…
kirktrue 5629d2c
Refactoring to use parameterized test for different fetch response er…
kirktrue 913fc8b
Added check for no pending requests in testEpochSetInFetchRequest
kirktrue e4c416c
Added clarifying comments to testFetchedRecordsAfterSeek
kirktrue dd95661
Updated fetch tests to use fetchRecordsInto utility method to reduce …
kirktrue b752bf8
Fixed typo in comments
kirktrue 8458f2c
Renamed and swapped 'expected' vs. 'actual' comparison in testMultipl…
kirktrue 7e39a74
Changed testReturnAbortedTransactionsinUncommittedMode() to testRetur…
kirktrue 2bd3635
Grammar/typo fix
kirktrue cd0e9ae
Moved comment in testPreferredReadReplicaOffsetError closer to applic…
kirktrue b18720f
Removed FetchEvent and added wakeup() method to ApplicationEventHandler
kirktrue f6093d6
Updates to change references to method namews
kirktrue 589bcc8
Removed outdated comment in testUnauthorizedTopic()
kirktrue e9d2bef
Test method name changed for clarity
kirktrue 44e7789
Removed unnecessarily comment from FetchRequestManagerTest.testFetche…
kirktrue 1eaad84
Updated variable name in FetchRequestManagerTest.testFetcherCloseClos…
kirktrue 9483363
On close, make the application thread wait for the network thread to …
kirktrue 99a65ec
Handle previously cached errors from getOffsetResetTimestamp
kirktrue 8372505
Updated wakeup() to be invoked only after receiving a non-empty Fetch
kirktrue fb4d1c2
Fixed misleading comment in FetcherTest/FetchRequestManagerTest testF…
kirktrue f40d4d2
Making NetworkClientDelegate constructor call another to eliminate re…
kirktrue 56d0b40
Merge branch 'trunk' into KAFKA-14274-3-introduce-fetch-request-manag…
kirktrue 13cb3b6
Ensure wakeupNetworkThread() is called even on empty Fetch results
kirktrue 9525fca
Changed OffsetFetcherUtils.offsetResetStrategyTimestamp to throw a No…
kirktrue c5d5fc6
Renamed refreshCommittedOffsetsIfNeeded to initWithCommittedOffsetsIf…
kirktrue File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.