MINOR: refactor(storage): topic-based RLMM consumer-manager/task related improvements#14045
Conversation
There was a problem hiding this comment.
This change should be reverted since the parameter is not updated.
There was a problem hiding this comment.
We should pass recordMetadata only, right?
There was a problem hiding this comment.
Of course, missed this one -- pushed fixes.
jeqo
changed the title
00e0848 to
d32810f
Compare
There was a problem hiding this comment.
Can we return an immutable Set of assignedMetaPartitions instead of topic-partitions as the topic names are repetitive? This is currently being passed to build a string of partitions in an Exception message here.
There was a problem hiding this comment.
Sure, applying suggestion
|
Rerunning CI build: https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14045/6/ |
|
@jeqo , there's a compilation error, could you take a look? Not sure if it is related to this fix: #14065 . If so, please try rebase to the latest trunk and see if it fixes it. Thanks. |
TBRLMM needs to create admin client at separate instances, and common set of configs already existing are enough -- no need to reuse producer/consumer configs
f7a78e6 to
64e1496
Compare
|
It seems to, force-pushed now. |
|
A few failed tests are observed on the Jenkins build jobs but they do not seem to be related, merging it to trunk. |
… consumer-manager/task (apache#14045) Improved logging and docs on consumer manager/task call paths. Reviewers: Luke Chen <showuon@gmail.com>, Satish Duggana <satishd@apache.org>
… consumer-manager/task (apache#14045) Improved logging and docs on consumer manager/task call paths. Reviewers: Luke Chen <showuon@gmail.com>, Satish Duggana <satishd@apache.org>
4 participants
Moving refactoring changes from #14012 into a separate PR.
Committer Checklist (excluded from commit message)