Skip to content

MINOR: Fix Jmxtool to enforce wait option when Object is not yet available in MBean server #13995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
omkreddy merged 1 commit into from
Jul 12, 2023
Merged

MINOR: Fix Jmxtool to enforce wait option when Object is not yet available in MBean server #13995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/src/main/java/org/apache/kafka/tools/JmxTool.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ private static Set<ObjectName> findObjects(JmxToolOptions options,
long waitTimeoutMs = 10_000;
Set<ObjectName> result = new HashSet<>();
Set<ObjectName> querySet = new HashSet<>(queries);
BiPredicate<Set<ObjectName>, Set<ObjectName>> foundAllObjects = Set::containsAll;
BiPredicate<Set<ObjectName>, Set<ObjectName>> foundAllObjects = Set::equals;
long start = System.currentTimeMillis();
do {
if (!result.isEmpty()) {
Expand Down
13 changes: 13 additions & 0 deletions tools/src/test/java/org/apache/kafka/tools/JmxToolTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,6 +337,19 @@ public void dateFormat() {
assertTrue(validDateFormat(dateFormat, csv.get("time")));
}

@Test
public void unknownObjectName() {
String[] args = new String[]{
"--jmx-url", jmxUrl,
"--object-name", "kafka.server:type=DummyMetrics,name=MessagesInPerSec",
"--wait"
};

String err = executeAndGetErr(args);
assertCommandFailure();
assertTrue(err.contains("Could not find all requested object names after 10000 ms"));
}

private static int findRandomOpenPortOnAllLocalInterfaces() throws Exception {
try (ServerSocket socket = new ServerSocket(0)) {
return socket.getLocalPort();
Expand Down