Skip to content

KAFKA-15159: upgrade minor dependencies#13982

Merged
divijvaidya merged 5 commits into
apache:trunkfrom
eziosudo:KAFKA-15159_update_dependencies
Jul 11, 2023
Merged

KAFKA-15159: upgrade minor dependencies#13982
divijvaidya merged 5 commits into
apache:trunkfrom
eziosudo:KAFKA-15159_update_dependencies

Conversation

@eziosudo

@eziosudo eziosudo commented Jul 10, 2023

Copy link
Copy Markdown
Contributor

Upgrade minor versions with backward compatible changes. Similar with #13673

Release notes for dependencies:

bcpkix 1.73 -> 1.75

Defects Fixed in 1.74 and 1.75. Addtional features and functionality in 1.74 doesn't impact Kafka.
Release notes:
https://www.bouncycastle.org/releasenotes.html#r1rv74
https://www.bouncycastle.org/releasenotes.html#r1rv75

jqwik 1.7.2 -> 1.7.4

Bug fixes. Breaking changes and new & enhancement features doesn't impact Kafka.
Release notes:
https://jqwik.net/release-notes.html#173
https://jqwik.net/release-notes.html#174

mavenArtifact 3.8.4 -> 3.8.8

Regression fixes and general fixes.
Release notes:
https://maven.apache.org/docs/3.8.5/release-notes.html
https://maven.apache.org/docs/3.8.6/release-notes.html
https://maven.apache.org/docs/3.8.7/release-notes.html
https://maven.apache.org/docs/3.8.8/release-notes.html

netty: 4.1.92.Final -> 4.1.94.Final

Bug fixes releases. Fix CVE-2023-34462
Release notes:
https://netty.io/news/2023/05/25/4-1-93-Final.html
https://netty.io/news/2023/06/19/4-1-94-Final.html

Compatibility

Verify build and test with JDK8 and JDK17.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@eziosudo eziosudo changed the title KAFKA-15159 upgrade minor dependencies KAFKA-15159: upgrade minor dependencies Jul 10, 2023

@divijvaidya divijvaidya left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes. We need to update the corresponding entries in LICENSE file too:

netty-buffer-4.1.92.Final

@divijvaidya divijvaidya added dependencies Pull requests that update a dependency file backport-candidate This pull request is a candidate to be backported to previous versions labels Jul 10, 2023
@mimaison

Copy link
Copy Markdown
Member

Thanks @divijvaidya for the PR. Should we update LICENSE-binary in the same PR, see https://github.com/apache/kafka/blob/trunk/gradle/dependencies.gradle#L73-L74

You'll have to update that file regardless when you run the release. But I think it's easier to keep it in sync if we do it when we bump dependencies.

@divijvaidya

Copy link
Copy Markdown
Member

Thanks @divijvaidya for the PR. Should we update LICENSE-binary in the same PR, see https://github.com/apache/kafka/blob/trunk/gradle/dependencies.gradle#L73-L74

You'll have to update that file regardless when you run the release. But I think it's easier to keep it in sync if we do it when we bump dependencies.

yes, I left the same comment for the author of the PR above. I will wait for them to update this PR until tomorrow.

@eziosudo

Copy link
Copy Markdown
Contributor Author

Thank you for the changes. We need to update the corresponding entries in LICENSE file too:

netty-buffer-4.1.92.Final

Thanks for the review. Already update LICENSE.

Comment thread gradle/dependencies.gradle Outdated
Comment thread gradle/dependencies.gradle Outdated

@divijvaidya divijvaidya left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scalaCollectionCompat has a new version 2.11, did we consider that?

@eziosudo

eziosudo commented Jul 11, 2023

Copy link
Copy Markdown
Contributor Author

scalaCollectionCompat has a new version 2.11, did we consider that?

Yes, just find the release note here, seems harmless.
https://github.com/scala/scala-collection-compat/releases/tag/v2.11.0

By the way, scalaLogging also has a new version '3.9.5', but the release notes didn't update, do you think we can upgrade it as well ?
https://github.com/lightbend-labs/scala-logging/releases
https://mvnrepository.com/artifact/com.typesafe.scala-logging/scala-logging
image

@divijvaidya divijvaidya left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes. Let's pick up scalaCollectionCompat and scala-logging in a separate PR since I don't want to block 3.5.1 on upgrading those two. They don't seem to bring in anything important.
Let's merge this one for now.

@divijvaidya

Copy link
Copy Markdown
Member

Unrelated test failures

[Build / JDK 20 and Scala 2.13 / org.apache.kafka.clients.admin.KafkaAdminClientTest.testClientSideTimeoutAfterFailureToReceiveResponse()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13982/4/testReport/junit/org.apache.kafka.clients.admin/KafkaAdminClientTest/Build___JDK_20_and_Scala_2_13___testClientSideTimeoutAfterFailureToReceiveResponse__/)
[Build / JDK 17 and Scala 2.13 / kafka.network.DynamicConnectionQuotaTest.testDynamicListenerConnectionCreationRateQuota()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13982/4/testReport/junit/kafka.network/DynamicConnectionQuotaTest/Build___JDK_17_and_Scala_2_13___testDynamicListenerConnectionCreationRateQuota__/)
[Build / JDK 17 and Scala 2.13 / org.apache.kafka.controller.QuorumControllerTest.testBalancePartitionLeaders()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13982/4/testReport/junit/org.apache.kafka.controller/QuorumControllerTest/Build___JDK_17_and_Scala_2_13___testBalancePartitionLeaders__/)
[Build / JDK 11 and Scala 2.13 / org.apache.kafka.controller.QuorumControllerTest.testBalancePartitionLeaders()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13982/4/testReport/junit/org.apache.kafka.controller/QuorumControllerTest/Build___JDK_11_and_Scala_2_13___testBalancePartitionLeaders__/)
[Build / JDK 8 and Scala 2.12 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationExactlyOnceTest.testOffsetTranslationBehindReplicationFlow()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13982/4/testReport/junit/org.apache.kafka.connect.mirror.integration/MirrorConnectorsIntegrationExactlyOnceTest/Build___JDK_8_and_Scala_2_12___testOffsetTranslationBehindReplicationFlow__/)
[Build / JDK 8 and Scala 2.12 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationExactlyOnceTest.testOffsetTranslationBehindReplicationFlow()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13982/4/testReport/junit/org.apache.kafka.connect.mirror.integration/MirrorConnectorsIntegrationExactlyOnceTest/Build___JDK_8_and_Scala_2_12___testOffsetTranslationBehindReplicationFlow___2/)

@divijvaidya
divijvaidya merged commit 6afcfba into apache:trunk Jul 11, 2023
divijvaidya pushed a commit that referenced this pull request Jul 11, 2023
Reviewers: Divij Vaidya <diviv@amazon.com>

---------

Co-authored-by: Damon Xie <damon.xie@zoom.us>
@eziosudo
eziosudo deleted the KAFKA-15159_update_dependencies branch July 11, 2023 20:39
Cerchie pushed a commit to Cerchie/kafka that referenced this pull request Jul 25, 2023
Reviewers: Divij Vaidya <diviv@amazon.com>

---------

Co-authored-by: Damon Xie <damon.xie@zoom.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-candidate This pull request is a candidate to be backported to previous versions dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants