MINOR:Move TROGDOR.md to trogdor module#13979
Merged
Merged
Conversation
divijvaidya
approved these changes
Jul 9, 2023
divijvaidya
self-requested a review
July 9, 2023 13:46
Member
|
I accidentally approved. Please ignore that. We need a lot many changed. If you search the code base, there are many references to TROGDOR.md, we need to change all of them. Also, it's referenced in build.gradle and |
Contributor
Author
sorry, I ignore that, and I have updated. @divijvaidya |
divijvaidya
approved these changes
Jul 10, 2023
divijvaidya
left a comment
divijvaidya
left a comment
Member
There was a problem hiding this comment.
Thank you for the change. LGTM!
Cerchie
pushed a commit
to Cerchie/kafka
that referenced
this pull request
Jul 25, 2023
Reviewers: Divij Vaidya <diviv@amazon.com> --------- Co-authored-by: Deqi Hu <deqi.hu@shopee.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
move TROGDOR.md in root dir to trogdor module, and rename to README.md