Kafka Streams Threading: Exception handling#13957
Merged
Merged
Conversation
Catch any exceptions that escape the processing logic inside TaskExecutors and record them in the TaskManager. Make sure the TaskExecutor survives, but the task is unassigned. Add a method to TaskManager to drain the exceptions. The aim here is that the polling thread will drain the exceptions to be able to execute the uncaught exception handler, abort transactions, etc.
cadonna
reviewed
Jul 5, 2023
| public void shouldNotSetUncaughtExceptionsForUnassignedTasks() { | ||
| taskManager.add(Collections.singleton(task)); | ||
|
|
||
| assertThrows(IllegalArgumentException.class, () -> taskManager.setUncaughtException(exception, task.id())); |
Member
There was a problem hiding this comment.
Could you please also verify the error message? Otherwise, we actually do not know which IllegalArgumentException was thrown.
| taskManager.assignNextTask(taskExecutor); | ||
| taskManager.setUncaughtException(exception, task.id()); | ||
|
|
||
| assertThrows(IllegalArgumentException.class, () -> taskManager.setUncaughtException(exception, task.id())); |
Member
There was a problem hiding this comment.
Could you please also verify the error message? Otherwise, we actually do not know which IllegalArgumentException was thrown.
Comment on lines
+188
to
+207
| @Test | ||
| public void shouldReturnExceptionsOnDrainExceptions() { | ||
| taskManager.add(Collections.singleton(task)); | ||
| when(tasks.activeTasks()).thenReturn(Collections.singleton(task)); | ||
| taskManager.assignNextTask(taskExecutor); | ||
| taskManager.setUncaughtException(exception, task.id()); | ||
|
|
||
| assertEquals(taskManager.drainUncaughtExceptions(), Collections.singletonMap(task.id(), exception)); | ||
| } | ||
|
|
||
| @Test | ||
| public void shouldClearExceptionsOnDrainExceptions() { | ||
| taskManager.add(Collections.singleton(task)); | ||
| when(tasks.activeTasks()).thenReturn(Collections.singleton(task)); | ||
| taskManager.assignNextTask(taskExecutor); | ||
| taskManager.setUncaughtException(exception, task.id()); | ||
| taskManager.drainUncaughtExceptions(); | ||
|
|
||
| assertEquals(taskManager.drainUncaughtExceptions(), Collections.emptyMap()); | ||
| } |
Member
There was a problem hiding this comment.
I think, it would be OK to merge these two tests. Just add the assertEquals() of the second test to the end of the first test.
| uncaughtExceptions.put(taskId, exception); | ||
| }); | ||
|
|
||
| log.info("Set an uncaught exception for task {}", taskId); |
Member
There was a problem hiding this comment.
Should we log some more information about the exception, like the type and the error message? Just to be able to better reason about the error case.
Comment on lines
+107
to
+108
| * Setting an uncaught exception for a task prevents it from being reassigned until the | ||
| * corresponding exception has been handled in the polling thread. |
Member
There was a problem hiding this comment.
That part is not yet implemented, right?
…nals/tasks/DefaultTaskExecutorTest.java Co-authored-by: Bruno Cadonna <cadonna@apache.org>
Member
Author
|
Test failures are unrelated |
Member
|
Build failures are unrelated: |
Cerchie
pushed a commit
to Cerchie/kafka
that referenced
this pull request
Jul 25, 2023
Catch any exceptions that escape the processing logic inside TaskExecutors and record them in the TaskManager. Make sure the TaskExecutor survives, but the task is unassigned. Add a method to TaskManager to drain the exceptions. The aim here is that the polling thread will drain the exceptions to be able to execute the uncaught exception handler, abort transactions, etc. Reviewer: Bruno Cadonna <cadonna@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Catch any exceptions that escape the processing logic inside TaskExecutors and record them in the TaskManager. Make sure the TaskExecutor survives, but the task is unassigned. Add a method to TaskManager to drain the exceptions. The aim here is that the polling thread will drain the exceptions to be able to execute the
uncaught exception handler, abort transactions, etc.
The logic is tested by basic unit tests.