Skip to content

KAFKA-15093: Add 3.4 and 3.5 to core upgrade and compatibility tests#13859

Merged
mimaison merged 1 commit into
apache:trunkfrom
mimaison:KAFKA-15093-core
Jul 12, 2023
Merged

KAFKA-15093: Add 3.4 and 3.5 to core upgrade and compatibility tests#13859
mimaison merged 1 commit into
apache:trunkfrom
mimaison:KAFKA-15093-core

Conversation

@mimaison

Copy link
Copy Markdown
Member

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@showuon showuon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cluster(num_nodes=6)
@parametrize(from_kafka_version=str(LATEST_3_5), to_message_format_version=None, compression_types=["none"])
@parametrize(from_kafka_version=str(LATEST_3_5), to_message_format_version=None, compression_types=["lz4"])
@parametrize(from_kafka_version=str(LATEST_3_5), to_message_format_version=None, compression_types=["snappy"])

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A general question because I have been going into this part of the codebase - is there a reason why the other two compression types are not tested (i.e. gzip, zstd)?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest I don't know. At this point, we've copied the same lines as the previous releases. Maybe this could be improved. If so I'd rather separate it from this PR and handle this out of a release.

@clolov clolov Jun 23, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I agree, this definitely needs to not be in this pull request, I was just wondering in case the answer was on top of your head

@clolov

clolov commented Jun 21, 2023

Copy link
Copy Markdown
Contributor

I believe this (https://github.com/apache/kafka/blob/trunk/tests/kafkatest/version.py#L246-L248) should be changed to

...
V_3_4_1 = KafkaVersion("3.4.1")
LATEST_3_4 = V_3_4_1

as part of this pull request, no?

You can ignore this, I saw that it is updated as part of another pull request.

@mimaison
mimaison merged commit b584e91 into apache:trunk Jul 12, 2023
@mimaison
mimaison deleted the KAFKA-15093-core branch July 12, 2023 08:37
Cerchie pushed a commit to Cerchie/kafka that referenced this pull request Jul 25, 2023
…stem tests (apache#13859)


Reviewers: Luke Chen <showuon@gmail.com>, Christo Lolov  <christololov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants