Skip to content

KAFKA-15059: Remove pending rebalance check when fencing zombie source connector tasks #13819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
viktorsomogyi merged 1 commit into from
Jun 16, 2023
Merged

KAFKA-15059: Remove pending rebalance check when fencing zombie source connector tasks #13819

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...test/java/org/apache/kafka/connect/mirror/integration/DedicatedMirrorIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@ public class DedicatedMirrorIntegrationTest {

private static final Logger log = LoggerFactory.getLogger(DedicatedMirrorIntegrationTest.class);

private static final int TOPIC_CREATION_TIMEOUT_MS = 30_000;
private static final int TOPIC_REPLICATION_TIMEOUT_MS = 30_000;
private static final int TOPIC_CREATION_TIMEOUT_MS = 120_000;
private static final int TOPIC_REPLICATION_TIMEOUT_MS = 120_000;

private Map<String, EmbeddedKafkaCluster> kafkaClusters;
private Map<String, MirrorMaker> mirrorMakers;
Expand Down
3 changes: 1 addition & 2 deletions ...runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1246,8 +1246,7 @@ void fenceZombieSourceTasks(final String connName, final Callback<Void> callback
private void doFenceZombieSourceTasks(String connName, Callback<Void> callback) {
log.trace("Performing zombie fencing request for connector {}", connName);

if (checkRebalanceNeeded(callback))
return;
// We don't have to check for a pending rebalance here

if (!isLeader())
callback.onCompletion(new NotLeaderException("Only the leader may perform zombie fencing.", leaderUrl()), null);
Expand Down