Skip to content

MINOR: fix a small typo in SharedServer.scala #13693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dengziming merged 1 commit into from
May 11, 2023
Merged

MINOR: fix a small typo in SharedServer.scala #13693

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions core/src/main/scala/kafka/server/SharedServer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ class SharedServer(
@volatile var brokerMetrics: BrokerServerMetrics = _
@volatile var controllerServerMetrics: ControllerMetadataMetrics = _
@volatile var loader: MetadataLoader = _
val snapshotsDiabledReason = new AtomicReference[String](null)
val snapshotsDisabledReason = new AtomicReference[String](null)
@volatile var snapshotEmitter: SnapshotEmitter = _
@volatile var snapshotGenerator: SnapshotGenerator = _

Expand Down Expand Up @@ -166,7 +166,7 @@ class SharedServer(
action = () => SharedServer.this.synchronized {
Option(brokerMetrics).foreach(_.metadataLoadErrorCount.getAndIncrement())
Option(controllerServerMetrics).foreach(_.incrementMetadataErrorCount())
snapshotsDiabledReason.compareAndSet(null, "metadata loading fault")
snapshotsDisabledReason.compareAndSet(null, "metadata loading fault")
})

/**
Expand All @@ -177,7 +177,7 @@ class SharedServer(
fatal = true,
action = () => SharedServer.this.synchronized {
Option(controllerServerMetrics).foreach(_.incrementMetadataErrorCount())
snapshotsDiabledReason.compareAndSet(null, "controller startup fault")
snapshotsDisabledReason.compareAndSet(null, "controller startup fault")
})

/**
Expand All @@ -189,7 +189,7 @@ class SharedServer(
action = () => SharedServer.this.synchronized {
Option(brokerMetrics).foreach(_.metadataApplyErrorCount.getAndIncrement())
Option(controllerServerMetrics).foreach(_.incrementMetadataErrorCount())
snapshotsDiabledReason.compareAndSet(null, "initial broker metadata loading fault")
snapshotsDisabledReason.compareAndSet(null, "initial broker metadata loading fault")
})

/**
Expand All @@ -200,7 +200,7 @@ class SharedServer(
fatal = true,
action = () => SharedServer.this.synchronized {
Option(controllerServerMetrics).foreach(_.incrementMetadataErrorCount())
snapshotsDiabledReason.compareAndSet(null, "quorum controller fault")
snapshotsDisabledReason.compareAndSet(null, "quorum controller fault")
})

/**
Expand Down Expand Up @@ -269,7 +269,7 @@ class SharedServer(
setFaultHandler(metadataPublishingFaultHandler).
setMaxBytesSinceLastSnapshot(sharedServerConfig.metadataSnapshotMaxNewRecordBytes).
setMaxTimeSinceLastSnapshotNs(TimeUnit.MILLISECONDS.toNanos(sharedServerConfig.metadataSnapshotMaxIntervalMs)).
setDisabledReason(snapshotsDiabledReason).
setDisabledReason(snapshotsDisabledReason).
setThreadNamePrefix(s"kafka-${sharedServerConfig.nodeId}-").
build()
_raftManager.register(loader)
Expand Down