Skip to content

KAFKA-14967: fix NPE in MockAdminClient CreateTopicsResult #13671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mimaison merged 1 commit into from
Jul 28, 2023
Merged

KAFKA-14967: fix NPE in MockAdminClient CreateTopicsResult #13671

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion clients/src/test/java/org/apache/kafka/clients/admin/MockAdminClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,13 +391,23 @@ synchronized public CreateTopicsResult createTopics(Collection<NewTopic> newTopi
topicIds.put(topicName, topicId);
topicNames.put(topicId, topicName);
allTopics.put(topicName, new TopicMetadata(topicId, false, partitions, logDirs, newTopic.configs()));
future.complete(null);
future.complete(new CreateTopicsResult.TopicMetadataAndConfig(topicId, numberOfPartitions, replicationFactor, config(newTopic)));
createTopicResult.put(topicName, future);
}

return new CreateTopicsResult(createTopicResult);
}

private static Config config(NewTopic newTopic) {
Collection<ConfigEntry> configEntries = new ArrayList<>();
if (newTopic.configs() != null) {
for (Map.Entry<String, String> entry : newTopic.configs().entrySet()) {
configEntries.add(new ConfigEntry(entry.getKey(), entry.getValue()));
}
}
return new Config(configEntries);
}

@Override
synchronized public ListTopicsResult listTopics(ListTopicsOptions options) {
Map<String, TopicListing> topicListings = new HashMap<>();
Expand Down