Skip to content

MINOR: Add reason to exceptions in QuorumController #13648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
showuon merged 2 commits into from
May 2, 2023
Merged

MINOR: Add reason to exceptions in QuorumController #13648

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5dbbea5
improve log
showuon Apr 27, 2023
0a911a2
add reason for InterruptedException
showuon Apr 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions server-common/src/main/java/org/apache/kafka/queue/KafkaEventQueue.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,12 +245,12 @@ private void handleEvents() throws InterruptedException {
continue;
} else if (interrupted) {
remove(eventContext);
toDeliver = new InterruptedException();
toDeliver = new InterruptedException("The event handler thread is interrupted");
toRun = eventContext;
continue;
} else if (shuttingDown) {
remove(eventContext);
toDeliver = new RejectedExecutionException();
toDeliver = new RejectedExecutionException("The event queue is shutting down");
toRun = eventContext;
continue;
}
Expand All @@ -264,7 +264,7 @@ private void handleEvents() throws InterruptedException {
}
} else {
if (interrupted) {
toDeliver = new InterruptedException();
toDeliver = new InterruptedException("The event handler thread is interrupted");
} else {
toDeliver = null;
}
Expand Down Expand Up @@ -300,10 +300,10 @@ Exception enqueue(EventContext eventContext,
lock.lock();
try {
if (shuttingDown) {
return new RejectedExecutionException();
return new RejectedExecutionException("The event queue is shutting down");
}
if (interrupted) {
return new InterruptedException();
return new InterruptedException("The event handler thread is interrupted");
}
OptionalLong existingDeadlineNs = OptionalLong.empty();
if (eventContext.tag != null) {
Expand Down