KAFKA-14848: KafkaConsumer incorrectly passes locally-scoped deserializers to FetchConfig#13452
Merged
guozhangwang merged 1 commit intoMar 27, 2023
Conversation
…ers to FetchConfig Fix for a NPE bug that was caused by referring to a local variable and not the instance variable of the deserializers. Co-Authored-By: Robert Yokota <1761488+rayokota@users.noreply.github.com>
kirktrue
changed the title
3 tasks
chia7712
reviewed
Mar 27, 2023
| this.clientRackId = config.getString(ConsumerConfig.CLIENT_RACK_CONFIG); | ||
| this.keyDeserializer = keyDeserializer; | ||
| this.valueDeserializer = valueDeserializer; | ||
| this.keyDeserializer = Objects.requireNonNull(keyDeserializer, "Message key deserializer provided to FetchConfig should not be null"); |
Member
There was a problem hiding this comment.
nit: how about calling another constructor to reduce duplicate code?
this(config.getInt(ConsumerConfig.FETCH_MIN_BYTES_CONFIG),
config.getInt(ConsumerConfig.FETCH_MAX_BYTES_CONFIG),
config.getInt(ConsumerConfig.FETCH_MAX_WAIT_MS_CONFIG)
...)
kirktrue
marked this pull request as ready for review
March 27, 2023 16:06
Contributor
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for a NPE bug that was caused by referring to a local variable and not the instance variable of the deserializers.
See fix suggestion from @rayokota: #13425 (comment)
Committer Checklist (excluded from commit message)