Skip to content

KAFKA-14059 Replace PowerMock with Mockito in WorkerSourceTaskTest #13383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
C0urante merged 15 commits into from
Jul 10, 2023
Merged

KAFKA-14059 Replace PowerMock with Mockito in WorkerSourceTaskTest #13383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
07f96fe
KAFKA-14059 Replace EasyMock and PowerMock with Mockito in WorkerSour…
hgeraldino Mar 4, 2023
97e208a
KAFKA-14059 Replace EasyMock and PowerMock with Mockito in WorkerSou…
hgeraldino Mar 13, 2023
34f4c7e
Few tweaks to make JDK8 builds happy
hgeraldino Mar 21, 2023
3b6bb8b
Update connect/runtime/src/test/java/org/apache/kafka/connect/runtime…
hgeraldino Mar 27, 2023
9996f6d
Update connect/runtime/src/test/java/org/apache/kafka/connect/runtime…
hgeraldino Apr 18, 2023
9e55cd9
Update connect/runtime/src/test/java/org/apache/kafka/connect/runtime…
hgeraldino Apr 18, 2023
611d76a
PR feedback
hgeraldino Apr 25, 2023
389d3f3
Update connect/runtime/src/test/java/org/apache/kafka/connect/runtime…
hgeraldino Jun 4, 2023
f7aa082
Update connect/runtime/src/test/java/org/apache/kafka/connect/runtime…
hgeraldino Jun 4, 2023
0b4c2fa
PR feedback
hgeraldino Jun 7, 2023
7a35f91
PR feedback
hgeraldino Jul 1, 2023
6562053
Update connect/runtime/src/test/java/org/apache/kafka/connect/runtime…
hgeraldino Jul 6, 2023
04fe47f
Update connect/runtime/src/test/java/org/apache/kafka/connect/runtime…
hgeraldino Jul 6, 2023
abe246e
Update connect/runtime/src/test/java/org/apache/kafka/connect/runtime…
hgeraldino Jul 6, 2023
8d71de4
Update connect/runtime/src/test/java/org/apache/kafka/connect/runtime…
hgeraldino Jul 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,8 +410,7 @@ subprojects {
"**/DistributedHerderTest.*",
"**/KafkaConfigBackingStoreTest.*",
"**/KafkaBasedLogTest.*", "**/StandaloneHerderTest.*",
"**/WorkerSinkTaskTest.*", "**/WorkerSinkTaskThreadedTest.*",
"**/WorkerSourceTaskTest.*"
"**/WorkerSinkTaskTest.*", "**/WorkerSinkTaskThreadedTest.*"
])
}

Expand Down
6 changes: 4 additions & 2 deletions connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@ class WorkerSourceTask extends AbstractWorkerSourceTask {
private static final Logger log = LoggerFactory.getLogger(WorkerSourceTask.class);

private volatile CommittableOffsets committableOffsets;
private final SubmittedRecords submittedRecords;
//VisibleForTesting
final SubmittedRecords submittedRecords;
private final AtomicReference<Exception> producerSendException;

public WorkerSourceTask(ConnectorTaskId id,
Expand Down Expand Up @@ -320,7 +321,8 @@ public boolean commitOffsets() {
return true;
}

private void updateCommittableOffsets() {
// Visible for testing
void updateCommittableOffsets() {
CommittableOffsets newOffsets = submittedRecords.committableOffsets();
synchronized (this) {
this.committableOffsets = this.committableOffsets.updatedWith(newOffsets);
Expand Down
Loading