MINOR: Improved error handling in ZK migration#13372
Merged
cmccabe merged 15 commits intoMar 16, 2023
Merged
Conversation
…ation-error-handling
cmccabe
reviewed
Mar 13, 2023
cmccabe
reviewed
Mar 13, 2023
cmccabe
reviewed
Mar 13, 2023
cmccabe
reviewed
Mar 13, 2023
cmccabe
reviewed
Mar 13, 2023
cmccabe
reviewed
Mar 13, 2023
| } | ||
|
|
||
| // First check the brokers registered in ZK | ||
| Set<Integer> zkBrokerRegistrations = new HashSet<>(zkMigrationClient.readBrokerIds()); |
Contributor
There was a problem hiding this comment.
is it necessary to copy the Set<Integer> we get back from zkMigrationClient.readBrokerIds? Seems like it should be fine to use directly...
Member
Author
There was a problem hiding this comment.
Ah, yea this is needed because the Set returned by the client was an immutable Scala thing originally. I'll change the client to return a mutable set
cmccabe
reviewed
Mar 13, 2023
cmccabe
reviewed
Mar 13, 2023
3 tasks
Contributor
|
@mumrah : |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes many small issues to improve error handling and logging during the ZK migration. A test was added to simulate a ZK session expiration to ensure the correctness of the migration driver.
With this change, ZK errors thrown during the migration will not hit the fault handler registered with with KRaftMigrationDriver, but they will be logged.