Skip to content

MINOR: Replace String literal with existing String variable#13305

Merged
chia7712 merged 1 commit into
apache:trunkfrom
hogimn:minor-replace
Feb 26, 2023
Merged

MINOR: Replace String literal with existing String variable#13305
chia7712 merged 1 commit into
apache:trunkfrom
hogimn:minor-replace

Conversation

@hogimn

@hogimn hogimn commented Feb 25, 2023

Copy link
Copy Markdown
Contributor

It is minor change.
I found out that String literal is used even though there is existing static String variable.
So, I replaced literal with variable.

Thank you :)

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@divijvaidya divijvaidya left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that this is your first change to this repository. Thank you and congratulations 🎉

The change look good, don't mind the failing build, our test suite suite is flaky. As a next step, one of the committers will drop in and merge your change.

@hogimn

hogimn commented Feb 25, 2023

Copy link
Copy Markdown
Contributor Author

Thanks for your kind reply :)
I am a newbie to Kafka and learning the concept and code through unit tests. I am happy to commit to this repository for the first time 😄.

@chia7712 chia7712 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and welcome to kafka :)

@chia7712
chia7712 merged commit dfd8fdb into apache:trunk Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants