MINOR: Replace String literal with existing String variable#13305
Merged
Conversation
divijvaidya
approved these changes
Feb 25, 2023
divijvaidya
left a comment
Member
There was a problem hiding this comment.
I see that this is your first change to this repository. Thank you and congratulations 🎉
The change look good, don't mind the failing build, our test suite suite is flaky. As a next step, one of the committers will drop in and merge your change.
Contributor
Author
|
Thanks for your kind reply :) |
chia7712
approved these changes
Feb 26, 2023
chia7712
left a comment
Member
There was a problem hiding this comment.
LGTM and welcome to kafka :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is minor change.
I found out that String literal is used even though there is existing static String variable.
So, I replaced literal with variable.
Thank you :)
Committer Checklist (excluded from commit message)