Skip to content

KAFKA-3665; Default ssl.endpoint.identification.algorithm should be https#1330

Closed
ijuma wants to merge 1 commit into
apache:trunkfrom
ijuma:kafka-3665-ssl-endpoint-identification-https
Closed

KAFKA-3665; Default ssl.endpoint.identification.algorithm should be https#1330
ijuma wants to merge 1 commit into
apache:trunkfrom
ijuma:kafka-3665-ssl-endpoint-identification-https

Conversation

@ijuma

@ijuma ijuma commented May 6, 2016

Copy link
Copy Markdown
Member

No description provided.

@ijuma

ijuma commented May 6, 2016

Copy link
Copy Markdown
Member Author

@rajinisivaram

Copy link
Copy Markdown
Contributor

@ijuma I have a feeling this would break system tests. It may be worth running the sanity tests to check. Shouldn't be too hard to fix though.

@rajinisivaram

Copy link
Copy Markdown
Contributor

@ijuma Ignore my comment - I didn't notice that you were already running the system tests :-)

@ijuma

ijuma commented May 6, 2016

Copy link
Copy Markdown
Member Author

@rajinisivaram I had the same feeling as you. :)

@harshach

Copy link
Copy Markdown

+1. Looks like it needs up merge.

@VanessaHenderson

Copy link
Copy Markdown

Any status on merging this fix?

@ijuma
ijuma force-pushed the kafka-3665-ssl-endpoint-identification-https branch from 5017c7d to 6485173 Compare June 7, 2016 03:40
@ijuma

ijuma commented Jun 7, 2016

Copy link
Copy Markdown
Member Author

@VanessaHenderson, we need to do more testing and potentially update the system tests before we can merge this.

@rajinisivaram

Copy link
Copy Markdown
Contributor

@ijuma Would you like me to update the system tests? I should be able to do it independent of the change to the default since it will be good to test with endpoint validation anyway.

@ijuma

ijuma commented Jun 7, 2016

Copy link
Copy Markdown
Member Author

@rajinisivaram, that would be great!

@omkreddy

Copy link
Copy Markdown
Contributor

Closing, as this fixed in #4956

@omkreddy omkreddy closed this Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants