Skip to content

KAFKA-14577: Move the scala ConsoleProducer from core to tools module #13214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Hangleton wants to merge 8 commits into from
Closed

KAFKA-14577: Move the scala ConsoleProducer from core to tools module #13214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2eef4af
Move ConsoleProducer to Java.
Hangleton Feb 7, 2023
411e462
Straight code move for ConsoleProducer.
Hangleton Feb 7, 2023
159674f
Add test to verify messages from the readers are sent by the producer.
Hangleton Feb 7, 2023
10f1c81
Add unit tests for LineMessageReader.
Hangleton Feb 7, 2023
91b3f6d
Remove scala ConsoleProducer, associated scala classes and scala unit…
Hangleton Feb 7, 2023
e9707b7
1) Add new class FQN in bat script; 2) Protect exit procedure with tr…
Hangleton Feb 8, 2023
990b88f
a) Re-use Header/RecordHeader from the client module to avoid duplica…
Hangleton Feb 9, 2023
277fb06
Rephrase.
Hangleton Feb 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin/kafka-console-producer.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@
if [ "x$KAFKA_HEAP_OPTS" = "x" ]; then
export KAFKA_HEAP_OPTS="-Xmx512M"
fi
exec $(dirname $0)/kafka-run-class.sh kafka.tools.ConsoleProducer "$@"
exec $(dirname $0)/kafka-run-class.sh org.apache.kafka.tools.ConsoleProducer "$@"

@clolov clolov Feb 8, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the same change needs to be done in bin/windows/kafka-console-producer.bat

2 changes: 1 addition & 1 deletion bin/windows/kafka-console-producer.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@ rem limitations under the License.

SetLocal
set KAFKA_HEAP_OPTS=-Xmx512M
"%~dp0kafka-run-class.bat" kafka.tools.ConsoleProducer %*
"%~dp0kafka-run-class.bat" org.apache.kafka.tools.ConsoleProducer %*
EndLocal
4 changes: 4 additions & 0 deletions checkstyle/import-control.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,6 +419,10 @@
<allow pkg="kafka.test" />
<allow pkg="joptsimple" />
<allow pkg="javax.rmi.ssl"/>
<allow pkg="org.apache.kafka.test" />
<allow pkg="org.apache.kafka.tools" />
<allow class="org.apache.kafka.tools.ConsoleProducer.ConsoleProducerConfig" />
<allow class="org.apache.kafka.tools.ConsoleProducer.LineMessageReader" />
</subpackage>

<subpackage name="trogdor">
Expand Down
2 changes: 1 addition & 1 deletion checkstyle/suppressions.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@
<suppress checks="BooleanExpressionComplexity"
files="StreamsResetter.java"/>
<suppress checks="NPathComplexity"
files="(ProducerPerformance|StreamsResetter|Agent|TransactionalMessageCopier).java"/>
files="(ProducerPerformance|StreamsResetter|Agent|TransactionalMessageCopier|LineMessageReader).java"/>
<suppress checks="ImportControl"
files="SignalLogger.java"/>
<suppress checks="IllegalImport"
Expand Down
39 changes: 0 additions & 39 deletions core/src/main/scala/kafka/common/MessageReader.scala
View file
Open in desktop

This file was deleted.

406 changes: 0 additions & 406 deletions core/src/main/scala/kafka/tools/ConsoleProducer.scala
View file
Open in desktop

This file was deleted.

223 changes: 0 additions & 223 deletions core/src/test/scala/unit/kafka/tools/ConsoleProducerTest.scala
View file
Open in desktop

This file was deleted.

Loading